fix On-Call spec #2572
Merged
fix On-Call spec #2572
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![api-clients-generation-pipeline[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
api-clients-generation-pipeline
bot
force-pushed
the
datadog-api-spec/generated/3892
branch
9 times, most recently
from
f782499 to
600ff9b
Compare
| def __init__( | ||
| self_, targets: Union[EscalationTarget, TeamTarget, UserTarget, ScheduleTarget, UnsetType] = unset, **kwargs | ||
| ): | ||
| def __init__(self_, targets: Union[EscalationTargets, UnsetType] = unset, **kwargs): |
There was a problem hiding this comment.
🔴 Code Quality Violation
Suggested change
| def __init__(self_, targets: Union[EscalationTargets, UnsetType] = unset, **kwargs): | |
| def __init__(self, targets: Union[EscalationTargets, UnsetType] = unset, **kwargs): |
first parameter of a class function should be self (...read more)
In a class method (that is not a class method nor a static method), the first argument must be self by convention.
Learn More
| time_zone: str, | ||
| tags: Union[List[str], UnsetType] = unset, | ||
| **kwargs, | ||
| self_, layers: List[ScheduleCreateRequestDataAttributesLayersItems], name: str, time_zone: str, **kwargs |
There was a problem hiding this comment.
🔴 Code Quality Violation
Suggested change
| self_, layers: List[ScheduleCreateRequestDataAttributesLayersItems], name: str, time_zone: str, **kwargs | |
| self, layers: List[ScheduleCreateRequestDataAttributesLayersItems], name: str, time_zone: str, **kwargs |
first parameter of a class function should be self (...read more)
In a class method (that is not a class method nor a static method), the first argument must be self by convention.
Learn More
| time_zone: str, | ||
| tags: Union[List[str], UnsetType] = unset, | ||
| **kwargs, | ||
| self_, layers: List[ScheduleUpdateRequestDataAttributesLayersItems], name: str, time_zone: str, **kwargs |
There was a problem hiding this comment.
🔴 Code Quality Violation
Suggested change
| self_, layers: List[ScheduleUpdateRequestDataAttributesLayersItems], name: str, time_zone: str, **kwargs | |
| self, layers: List[ScheduleUpdateRequestDataAttributesLayersItems], name: str, time_zone: str, **kwargs |
first parameter of a class function should be self (...read more)
In a class method (that is not a class method nor a static method), the first argument must be self by convention.
Learn More
| } | ||
|
|
||
| def __init__( | ||
| self_, |
There was a problem hiding this comment.
🔴 Code Quality Violation
Suggested change
| self_, | |
| self, |
first parameter of a class function should be self (...read more)
In a class method (that is not a class method nor a static method), the first argument must be self by convention.
Learn More
| time_zone: Union[str, UnsetType] = unset, | ||
| **kwargs, | ||
| ): | ||
| def __init__(self_, name: Union[str, UnsetType] = unset, time_zone: Union[str, UnsetType] = unset, **kwargs): |
There was a problem hiding this comment.
🔴 Code Quality Violation
Suggested change
| def __init__(self_, name: Union[str, UnsetType] = unset, time_zone: Union[str, UnsetType] = unset, **kwargs): | |
| def __init__(self, name: Union[str, UnsetType] = unset, time_zone: Union[str, UnsetType] = unset, **kwargs): |
first parameter of a class function should be self (...read more)
In a class method (that is not a class method nor a static method), the first argument must be self by convention.
Learn More
| } | ||
|
|
||
| attribute_map = { | ||
| "identifier": "identifier", | ||
| "type": "type", | ||
| } | ||
|
|
||
| def __init__(self_, identifier: Union[str, UnsetType] = unset, type: Union[str, UnsetType] = unset, **kwargs): | ||
| def __init__( | ||
| self_, identifier: Union[str, UnsetType] = unset, type: Union[OnCallPageTargetType, UnsetType] = unset, **kwargs |
There was a problem hiding this comment.
🔴 Code Quality Violation
Suggested change
| self_, identifier: Union[str, UnsetType] = unset, type: Union[OnCallPageTargetType, UnsetType] = unset, **kwargs | |
| self, identifier: Union[str, UnsetType] = unset, type: Union[OnCallPageTargetType, UnsetType] = unset, **kwargs |
first parameter of a class function should be self (...read more)
In a class method (that is not a class method nor a static method), the first argument must be self by convention.
Learn More
api-clients-generation-pipeline
bot
force-pushed
the
datadog-api-spec/generated/3892
branch
2 times, most recently
from
b4429ae to
a0faecd
Compare
skarimo
approved these changes
May 23, 2025
api-clients-generation-pipeline
bot
force-pushed
the
datadog-api-spec/generated/3892
branch
from
a0faecd to
4710cb0
Compare
api-clients-generation-pipeline
bot
deleted the
datadog-api-spec/generated/3892
branch
github-actions bot
pushed a commit
that referenced
this pull request
May 26, 2025
Co-authored-by: ci.datadog-api-spec <packages@datadoghq.com> debc5df
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See DataDog/datadog-api-spec#3892
Test branch datadog-api-spec/test/bndbsh/oncall-tweaks