Skip to content

[ACIX-616] Stack cleaner migration: enable it everywhere #39220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

CelianR
Copy link
Contributor

@CelianR CelianR commented Jul 24, 2025

What does this PR do?

Enable Stack Cleaner on every e2e job

Motivation

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

@CelianR CelianR self-assigned this Jul 24, 2025
@CelianR CelianR added changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation labels Jul 24, 2025
@CelianR CelianR changed the base branch from main to celian/stackcleaner-enable-eks-acix-616 July 24, 2025 07:29
@github-actions github-actions bot added the short review PR is simple enough to be reviewed quickly label Jul 24, 2025
@CelianR CelianR marked this pull request as ready for review July 24, 2025 07:31
@CelianR CelianR requested review from a team as code owners July 24, 2025 07:31
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Jul 24, 2025

Gitlab CI Configuration Changes

⚠️ Diff too large to display on Github.

Changes Summary

Removed Modified Added Renamed
0 118 0 0

ℹ️ Diff available in the job log.

Copy link

cit-pr-commenter bot commented Jul 24, 2025

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: c338298b-fbb5-45c4-bf50-4457afcd0abb

Baseline: 3d21c4a
Comparison: 5ff54a6
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization +2.31 [-0.81, +5.44] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_logs % cpu utilization +3.05 [+0.19, +5.90] 1 Logs bounds checks dashboard
docker_containers_cpu % cpu utilization +2.31 [-0.81, +5.44] 1 Logs
quality_gate_metrics_logs memory utilization +2.21 [+1.81, +2.61] 1 Logs bounds checks dashboard
docker_containers_memory memory utilization +0.49 [+0.43, +0.55] 1 Logs
uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization +0.26 [+0.22, +0.30] 1 Logs
otlp_ingest_logs memory utilization +0.19 [+0.07, +0.31] 1 Logs
quality_gate_idle memory utilization +0.16 [+0.12, +0.20] 1 Logs bounds checks dashboard
ddot_metrics memory utilization +0.14 [+0.02, +0.25] 1 Logs
ddot_logs memory utilization +0.08 [-0.01, +0.17] 1 Logs
file_to_blackhole_1000ms_latency egress throughput +0.05 [-0.58, +0.68] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.01 [-0.01, +0.04] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.01 [-0.30, +0.31] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.00 [-0.60, +0.61] 1 Logs
file_tree memory utilization -0.00 [-0.04, +0.04] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.03 [-0.62, +0.55] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.03 [-0.63, +0.57] 1 Logs
otlp_ingest_metrics memory utilization -0.29 [-0.43, -0.15] 1 Logs
tcp_syslog_to_blackhole ingress throughput -0.52 [-0.58, -0.45] 1 Logs
quality_gate_idle_all_features memory utilization -0.60 [-0.63, -0.57] 1 Logs bounds checks dashboard

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
docker_containers_cpu simple_check_run 10/10
docker_containers_memory memory_usage 10/10
docker_containers_memory simple_check_run 10/10
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_logs memory_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 bounds checks dashboard
quality_gate_metrics_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Jul 24, 2025

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 3d21c4a

Successful checks

Info

Quality gate Delta On disk size (MiB) Delta On wire size (MiB)
agent_deb_amd64 $${+0}$$ $${704.76}$$ < $${704.84}$$ $${-0.03}$$ $${177.89}$$ < $${178.58}$$
agent_deb_amd64_fips $${+0}$$ $${703.01}$$ < $${703.09}$$ $${-0.04}$$ $${177.37}$$ < $${178.12}$$
agent_heroku_amd64 $${+0}$$ $${354.62}$$ < $${355.37}$$ $${+0}$$ $${94.86}$$ < $${95.72}$$
agent_msi $${+0}$$ $${979.37}$$ < $${979.61}$$ $${-0.03}$$ $${148.64}$$ < $${149.31}$$
agent_rpm_amd64 $${+0}$$ $${704.75}$$ < $${704.83}$$ $${-0.05}$$ $${179.56}$$ < $${180.22}$$
agent_rpm_amd64_fips $${+0}$$ $${702.99}$$ < $${703.08}$$ $${-0.01}$$ $${179.24}$$ < $${179.85}$$
agent_rpm_arm64 $${+0}$$ $${694.54}$$ < $${694.74}$$ $${-0.05}$$ $${163.24}$$ < $${163.96}$$
agent_rpm_arm64_fips $${+0}$$ $${692.86}$$ < $${693.05}$$ $${+0.01}$$ $${162.24}$$ < $${163.0}$$
agent_suse_amd64 $${+0}$$ $${704.75}$$ < $${704.83}$$ $${-0.05}$$ $${179.56}$$ < $${180.22}$$
agent_suse_amd64_fips $${+0}$$ $${702.99}$$ < $${703.08}$$ $${-0.01}$$ $${179.24}$$ < $${179.85}$$
agent_suse_arm64 $${+0}$$ $${694.54}$$ < $${694.74}$$ $${-0.05}$$ $${163.24}$$ < $${163.96}$$
agent_suse_arm64_fips $${+0}$$ $${692.86}$$ < $${693.05}$$ $${+0.01}$$ $${162.24}$$ < $${163.0}$$
docker_agent_amd64 $${+0}$$ $${788.5}$$ < $${788.65}$$ $${+0.01}$$ $${271.39}$$ < $${272.01}$$
docker_agent_arm64 $${+0}$$ $${801.81}$$ < $${802.0}$$ $${-0.02}$$ $${259.01}$$ < $${259.7}$$
docker_agent_jmx_amd64 $${+0}$$ $${979.75}$$ < $${979.84}$$ $${-0.01}$$ $${340.39}$$ < $${340.95}$$
docker_agent_jmx_arm64 $${+0}$$ $${981.65}$$ < $${981.8}$$ $${-0.01}$$ $${324.0}$$ < $${324.65}$$
docker_cluster_agent_amd64 $${+0}$$ $${213.91}$$ < $${214.5}$$ $${+0}$$ $${72.72}$$ < $${73.51}$$
docker_cluster_agent_arm64 $${-0}$$ $${229.75}$$ < $${230.33}$$ $${-0}$$ $${68.97}$$ < $${69.77}$$
docker_cws_instrumentation_amd64 $${0}$$ $${7.07}$$ < $${7.12}$$ $${+0}$$ $${2.95}$$ < $${3.29}$$
docker_cws_instrumentation_arm64 $${+0}$$ $${6.69}$$ < $${6.92}$$ $${+0}$$ $${2.7}$$ < $${3.07}$$
docker_dogstatsd_amd64 $${+0}$$ $${38.55}$$ < $${39.57}$$ $${+0}$$ $${14.88}$$ < $${15.76}$$
docker_dogstatsd_arm64 $${-0}$$ $${37.23}$$ < $${38.2}$$ $${+0}$$ $${14.33}$$ < $${14.83}$$
dogstatsd_deb_amd64 $${0}$$ $${29.79}$$ < $${31.4}$$ $${+0}$$ $${7.84}$$ < $${8.95}$$
dogstatsd_deb_arm64 $${0}$$ $${28.39}$$ < $${29.97}$$ $${+0}$$ $${6.81}$$ < $${7.89}$$
dogstatsd_rpm_amd64 $${0}$$ $${29.79}$$ < $${31.4}$$ $${+0}$$ $${7.86}$$ < $${8.96}$$
dogstatsd_suse_amd64 $${0}$$ $${29.79}$$ < $${31.4}$$ $${+0}$$ $${7.86}$$ < $${8.96}$$
iot_agent_deb_amd64 $${0}$$ $${54.06}$$ < $${54.55}$$ $${-0}$$ $${13.63}$$ < $${14.45}$$
iot_agent_deb_arm64 $${0}$$ $${51.38}$$ < $${51.9}$$ $${+0}$$ $${11.79}$$ < $${12.63}$$
iot_agent_deb_armhf $${0}$$ $${50.9}$$ < $${51.42}$$ $${-0.03}$$ $${11.87}$$ < $${12.74}$$
iot_agent_rpm_amd64 $${0}$$ $${54.06}$$ < $${54.55}$$ $${-0}$$ $${13.65}$$ < $${14.47}$$
iot_agent_rpm_arm64 $${0}$$ $${51.38}$$ < $${51.91}$$ $${-0}$$ $${11.81}$$ < $${12.65}$$
iot_agent_suse_amd64 $${0}$$ $${54.06}$$ < $${54.55}$$ $${-0}$$ $${13.65}$$ < $${14.47}$$

Copy link
Member

@chouetz chouetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

Copy link
Member

@chouetz chouetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 🔥

Base automatically changed from celian/stackcleaner-enable-eks-acix-616 to main July 28, 2025 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation short review PR is simple enough to be reviewed quickly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants