CAP-2684 Add unit tests for Metadata and Manifest chunking and buffering

[kangyili]

What does this PR do?

For chunking, we already have TestChunkOrchestratorMetadataBySizeAndWeight. This PR moves the test to the right file.
For buffering, we already have TestOrchestratorManifestBuffer. This PR just add a new to for NewManifestBuffer

[cit-pr-commenter]

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 45719033-ad28-49c8-8ae9-68b7da29f260

Baseline: a30b8e4
Comparison: b642023
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	docker_containers_cpu	% cpu utilization	-0.33	[-3.42, +2.75]	1	Logs

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	docker_containers_memory	memory utilization	+0.47	[+0.41, +0.53]	1	Logs
➖	quality_gate_idle_all_features	memory utilization	+0.25	[+0.22, +0.29]	1	Logs bounds checks dashboard
➖	quality_gate_logs	% cpu utilization	+0.23	[-2.53, +2.99]	1	Logs bounds checks dashboard
➖	uds_dogstatsd_20mb_12k_contexts_20_senders	memory utilization	+0.10	[+0.06, +0.14]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	+0.01	[-0.62, +0.64]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	+0.00	[-0.61, +0.61]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	+0.00	[-0.01, +0.01]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	-0.00	[-0.32, +0.32]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	-0.04	[-0.64, +0.56]	1	Logs
➖	ddot_logs	memory utilization	-0.07	[-0.16, +0.02]	1	Logs
➖	otlp_ingest_logs	memory utilization	-0.09	[-0.22, +0.03]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	-0.17	[-0.74, +0.40]	1	Logs
➖	file_tree	memory utilization	-0.24	[-0.28, -0.20]	1	Logs
➖	otlp_ingest_metrics	memory utilization	-0.25	[-0.39, -0.10]	1	Logs
➖	ddot_metrics	memory utilization	-0.26	[-0.38, -0.14]	1	Logs
➖	quality_gate_idle	memory utilization	-0.30	[-0.35, -0.26]	1	Logs bounds checks dashboard
➖	quality_gate_metrics_logs	memory utilization	-0.31	[-0.69, +0.07]	1	Logs bounds checks dashboard
➖	docker_containers_cpu	% cpu utilization	-0.33	[-3.42, +2.75]	1	Logs
➖	tcp_syslog_to_blackhole	ingress throughput	-0.85	[-0.91, -0.79]	1	Logs

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	links
✅	docker_containers_cpu	simple_check_run	10/10
✅	docker_containers_memory	memory_usage	10/10
✅	docker_containers_memory	simple_check_run	10/10
✅	file_to_blackhole_0ms_latency	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10
✅	file_to_blackhole_100ms_latency	lost_bytes	10/10
✅	file_to_blackhole_100ms_latency	memory_usage	10/10
✅	file_to_blackhole_500ms_latency	lost_bytes	10/10
✅	file_to_blackhole_500ms_latency	memory_usage	10/10
✅	quality_gate_idle	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_logs	lost_bytes	10/10	bounds checks dashboard
✅	quality_gate_logs	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_metrics_logs	cpu_usage	10/10	bounds checks dashboard
✅	quality_gate_metrics_logs	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_metrics_logs	lost_bytes	10/10	bounds checks dashboard
✅	quality_gate_metrics_logs	memory_usage	10/10	bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

• quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.

[agent-platform-auto-pr]

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor a30b8e4

Successful checks

Info

	Quality gate	Delta	On disk size (MiB)	Delta	On wire size (MiB)
✅	agent_deb_amd64	$${+0}$$	$${703.32}$$ < $${703.45}$$	$${+0.03}$$	$${177.63}$$ < $${178.35}$$
✅	agent_deb_amd64_fips	$${+0}$$	$${701.58}$$ < $${701.7}$$	$${+0.04}$$	$${177.03}$$ < $${177.76}$$
✅	agent_heroku_amd64	$${+0}$$	$${354.6}$$ < $${355.37}$$	$${-0}$$	$${94.86}$$ < $${95.72}$$
✅	agent_msi	$${0}$$	$${977.83}$$ < $${978.18}$$	$${+0.03}$$	$${148.64}$$ < $${149.26}$$
✅	agent_rpm_amd64	$${+0}$$	$${703.31}$$ < $${703.44}$$	$${+0.01}$$	$${179.27}$$ < $${179.87}$$
✅	agent_rpm_amd64_fips	$${+0}$$	$${701.57}$$ < $${701.69}$$	$${+0.06}$$	$${178.89}$$ < $${179.47}$$
✅	agent_rpm_arm64	$${-0}$$	$${693.24}$$ < $${693.48}$$	$${+0.01}$$	$${162.93}$$ < $${163.62}$$
✅	agent_rpm_arm64_fips	$${-0}$$	$${691.55}$$ < $${691.79}$$	$${-0.01}$$	$${161.9}$$ < $${162.65}$$
✅	agent_suse_amd64	$${+0}$$	$${703.31}$$ < $${703.44}$$	$${+0.01}$$	$${179.27}$$ < $${179.87}$$
✅	agent_suse_amd64_fips	$${+0}$$	$${701.57}$$ < $${701.69}$$	$${+0.06}$$	$${178.89}$$ < $${179.47}$$
✅	agent_suse_arm64	$${-0}$$	$${693.24}$$ < $${693.48}$$	$${+0.01}$$	$${162.93}$$ < $${163.62}$$
✅	agent_suse_arm64_fips	$${-0}$$	$${691.55}$$ < $${691.79}$$	$${-0.01}$$	$${161.9}$$ < $${162.65}$$
✅	docker_agent_amd64	$${+0}$$	$${787.07}$$ < $${787.26}$$	$${+0.01}$$	$${270.88}$$ < $${271.51}$$
✅	docker_agent_arm64	$${-0}$$	$${800.51}$$ < $${800.74}$$	$${-0.01}$$	$${258.52}$$ < $${259.24}$$
✅	docker_agent_jmx_amd64	$${+0}$$	$${978.32}$$ < $${978.45}$$	$${-0.01}$$	$${339.89}$$ < $${340.47}$$
✅	docker_agent_jmx_arm64	$${-0}$$	$${980.35}$$ < $${980.54}$$	$${-0}$$	$${323.52}$$ < $${324.2}$$
✅	docker_cluster_agent_amd64	$${+0}$$	$${213.89}$$ < $${214.5}$$	$${-0}$$	$${72.71}$$ < $${73.51}$$
✅	docker_cluster_agent_arm64	$${-0}$$	$${229.74}$$ < $${230.33}$$	$${-0}$$	$${68.96}$$ < $${69.77}$$
✅	docker_cws_instrumentation_amd64	$${0}$$	$${7.07}$$ < $${7.12}$$	$${+0}$$	$${2.95}$$ < $${3.29}$$
✅	docker_cws_instrumentation_arm64	$${0}$$	$${6.69}$$ < $${6.92}$$	$${+0}$$	$${2.7}$$ < $${3.07}$$
✅	docker_dogstatsd_amd64	$${0}$$	$${38.55}$$ < $${39.57}$$	$${-0}$$	$${14.88}$$ < $${15.76}$$
✅	docker_dogstatsd_arm64	$${0}$$	$${37.23}$$ < $${38.2}$$	$${-0}$$	$${14.33}$$ < $${14.83}$$
✅	dogstatsd_deb_amd64	$${0}$$	$${29.78}$$ < $${31.4}$$	$${-0}$$	$${7.84}$$ < $${8.95}$$
✅	dogstatsd_deb_arm64	$${0}$$	$${28.39}$$ < $${29.97}$$	$${-0}$$	$${6.81}$$ < $${7.89}$$
✅	dogstatsd_rpm_amd64	$${0}$$	$${29.78}$$ < $${31.4}$$	$${+0}$$	$${7.86}$$ < $${8.96}$$
✅	dogstatsd_suse_amd64	$${0}$$	$${29.78}$$ < $${31.4}$$	$${+0}$$	$${7.86}$$ < $${8.96}$$
✅	iot_agent_deb_amd64	$${0}$$	$${54.05}$$ < $${54.55}$$	$${-0}$$	$${13.63}$$ < $${14.45}$$
✅	iot_agent_deb_arm64	$${0}$$	$${51.37}$$ < $${51.9}$$	$${-0}$$	$${11.79}$$ < $${12.63}$$
✅	iot_agent_deb_armhf	$${0}$$	$${50.88}$$ < $${51.42}$$	$${-0.04}$$	$${11.87}$$ < $${12.74}$$
✅	iot_agent_rpm_amd64	$${0}$$	$${54.05}$$ < $${54.55}$$	$${+0}$$	$${13.64}$$ < $${14.47}$$
✅	iot_agent_rpm_arm64	$${0}$$	$${51.37}$$ < $${51.91}$$	$${-0}$$	$${11.81}$$ < $${12.65}$$
✅	iot_agent_suse_amd64	$${0}$$	$${54.05}$$ < $${54.55}$$	$${+0}$$	$${13.64}$$ < $${14.47}$$

[fisherevans]

I think we need to add a test for the flushing, which is where we had a regression last time - we were not generating the right tags before the context was not being constructed correctly.

datadog-agent/pkg/collector/corechecks/cluster/orchestrator/manifest_buffer.go

Lines 91 to 109 in 406ee75

	func (cb *ManifestBuffer) flushManifest(sender sender.Sender) {
	manifests := cb.bufferedManifests
	ctx := &processors.K8sProcessorContext{
	BaseProcessorContext: processors.BaseProcessorContext{
	MsgGroupID: cb.Cfg.MsgGroupRef.Inc(),
	Cfg: &config.OrchestratorConfig{
	KubeClusterName: cb.Cfg.KubeClusterName,
	MaxPerMessage: cb.Cfg.MaxPerMessage,
	MaxWeightPerMessageBytes: cb.Cfg.MaxWeightPerMessageBytes,
	ExtraTags: cb.Cfg.ExtraTags,
	},
	ClusterID: cb.Cfg.ClusterID,
	},
	}
	manifestMessages := processors.ChunkManifest(ctx, common.BaseHandlers{}.BuildManifestMessageBody, manifests)
	sender.OrchestratorManifest(manifestMessages, cb.Cfg.ClusterID)
	setManifestStats(manifests)
	cb.bufferedManifests = cb.bufferedManifests[:0]
	}

[kangyili]

I think we need to add a test for the flushing, which is where we had a regression last time - we were not generating the right tags before the context was not being constructed correctly.

datadog-agent/pkg/collector/corechecks/cluster/orchestrator/manifest_buffer.go

Lines 91 to 109 in 406ee75

	func (cb *ManifestBuffer) flushManifest(sender sender.Sender) {
	manifests := cb.bufferedManifests
	ctx := &processors.K8sProcessorContext{
	BaseProcessorContext: processors.BaseProcessorContext{
	MsgGroupID: cb.Cfg.MsgGroupRef.Inc(),
	Cfg: &config.OrchestratorConfig{
	KubeClusterName: cb.Cfg.KubeClusterName,
	MaxPerMessage: cb.Cfg.MaxPerMessage,
	MaxWeightPerMessageBytes: cb.Cfg.MaxWeightPerMessageBytes,
	ExtraTags: cb.Cfg.ExtraTags,
	},
	ClusterID: cb.Cfg.ClusterID,
	},
	}
	manifestMessages := processors.ChunkManifest(ctx, common.BaseHandlers{}.BuildManifestMessageBody, manifests)
	sender.OrchestratorManifest(manifestMessages, cb.Cfg.ClusterID)
	setManifestStats(manifests)
	cb.bufferedManifests = cb.bufferedManifests[:0]
	}

I think you added it

datadog-agent/pkg/collector/corechecks/cluster/orchestrator/manifest_buffer_test.go

Line 46 in 406ee75

Tags: []string{"tag_for:type1"},

I can add another one b642023