-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[Backport 7.68.x] remoteconfig: add LIVE_DEBUGGING_SYMBOL_DB product #39199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The dd-trace-go library depends on this package for its remote config repository implementation. It cannot parse updates to this product without it being listed as valid.
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: db168a9 Optimization Goals: ✅ No significant changes detected
|
perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
---|---|---|---|---|---|---|
➖ | docker_containers_cpu | % cpu utilization | +2.84 | [-0.10, +5.77] | 1 | Logs |
➖ | quality_gate_idle_all_features | memory utilization | +0.77 | [+0.72, +0.83] | 1 | Logs bounds checks dashboard |
➖ | quality_gate_idle | memory utilization | +0.40 | [+0.34, +0.46] | 1 | Logs bounds checks dashboard |
➖ | ddot_logs | memory utilization | +0.40 | [+0.28, +0.52] | 1 | Logs |
➖ | otlp_ingest_metrics | memory utilization | +0.13 | [-0.05, +0.31] | 1 | Logs |
➖ | file_to_blackhole_300ms_latency | egress throughput | +0.12 | [-0.49, +0.74] | 1 | Logs |
➖ | file_to_blackhole_0ms_latency | egress throughput | +0.11 | [-0.50, +0.71] | 1 | Logs |
➖ | uds_dogstatsd_20mb_12k_contexts_20_senders | memory utilization | +0.11 | [+0.06, +0.15] | 1 | Logs |
➖ | file_tree | memory utilization | +0.09 | [+0.02, +0.15] | 1 | Logs |
➖ | file_to_blackhole_0ms_latency_http2 | egress throughput | +0.09 | [-0.50, +0.67] | 1 | Logs |
➖ | file_to_blackhole_100ms_latency | egress throughput | +0.05 | [-0.56, +0.67] | 1 | Logs |
➖ | file_to_blackhole_1000ms_latency | egress throughput | +0.03 | [-0.53, +0.60] | 1 | Logs |
➖ | docker_containers_memory | memory utilization | +0.01 | [-0.07, +0.10] | 1 | Logs |
➖ | file_to_blackhole_500ms_latency | egress throughput | +0.01 | [-0.64, +0.66] | 1 | Logs |
➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.00 | [-0.02, +0.03] | 1 | Logs |
➖ | uds_dogstatsd_to_api | ingress throughput | -0.00 | [-0.29, +0.28] | 1 | Logs |
➖ | file_to_blackhole_1000ms_latency_linear_load | egress throughput | -0.02 | [-0.26, +0.22] | 1 | Logs |
➖ | file_to_blackhole_0ms_latency_http1 | egress throughput | -0.03 | [-0.59, +0.53] | 1 | Logs |
➖ | otlp_ingest_logs | memory utilization | -0.11 | [-0.24, +0.02] | 1 | Logs |
➖ | tcp_syslog_to_blackhole | ingress throughput | -0.15 | [-0.21, -0.09] | 1 | Logs |
➖ | ddot_metrics | memory utilization | -0.23 | [-0.35, -0.11] | 1 | Logs |
➖ | quality_gate_logs | % cpu utilization | -1.31 | [-3.96, +1.35] | 1 | Logs bounds checks dashboard |
➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | -1.33 | [-2.16, -0.49] | 1 | Logs |
Bounds Checks: ❌ Failed
perf | experiment | bounds_check_name | replicates_passed | links |
---|---|---|---|---|
❌ | docker_containers_cpu | simple_check_run | 0/10 | |
✅ | docker_containers_memory | memory_usage | 10/10 | |
❌ | docker_containers_memory | simple_check_run | 0/10 | |
✅ | file_to_blackhole_0ms_latency | lost_bytes | 10/10 | |
✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_0ms_latency_http1 | lost_bytes | 10/10 | |
✅ | file_to_blackhole_0ms_latency_http1 | memory_usage | 10/10 | |
✅ | file_to_blackhole_0ms_latency_http2 | lost_bytes | 10/10 | |
✅ | file_to_blackhole_0ms_latency_http2 | memory_usage | 10/10 | |
✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_1000ms_latency_linear_load | memory_usage | 10/10 | |
✅ | file_to_blackhole_100ms_latency | lost_bytes | 10/10 | |
✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_300ms_latency | lost_bytes | 10/10 | |
✅ | file_to_blackhole_300ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_500ms_latency | lost_bytes | 10/10 | |
✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | |
✅ | quality_gate_idle | intake_connections | 10/10 | bounds checks dashboard |
✅ | quality_gate_idle | memory_usage | 10/10 | bounds checks dashboard |
✅ | quality_gate_idle_all_features | intake_connections | 10/10 | bounds checks dashboard |
✅ | quality_gate_idle_all_features | memory_usage | 10/10 | bounds checks dashboard |
✅ | quality_gate_logs | intake_connections | 10/10 | bounds checks dashboard |
✅ | quality_gate_logs | lost_bytes | 10/10 | bounds checks dashboard |
✅ | quality_gate_logs | memory_usage | 10/10 | bounds checks dashboard |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
Static quality checks✅ Please find below the results from static quality gates Successful checksInfo
|
What does this PR do?
The dd-trace-go library depends on this package for its remote config repository implementation. It cannot parse updates to this product without it being listed as valid.
Motivation
The Live Debugger team needs dd-trace-go to be able to subscribe to this product. This library is used in
dd-trace-go
. We'd like to backport this non-functional change into datadog-agent so that dd-trace-go can adopt it without having to bump the major version of thedatadog-agent
dependency and pick up the changes to transitive dependencies.Additional Notes
Relates to https://datadoghq.atlassian.net/browse/DEBUG-4206