-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[Backport 7.69.x] remoteconfig: add LIVE_DEBUGGING_SYMBOL_DB product #39198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
(cherry picked from commit a30b8e4)
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: d9ae115 Optimization Goals: ✅ No significant changes detected
|
perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
---|---|---|---|---|---|---|
➖ | docker_containers_cpu | % cpu utilization | +4.93 | [+1.70, +8.15] | 1 | Logs |
Fine details of change detection per experiment
perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
---|---|---|---|---|---|---|
➖ | docker_containers_cpu | % cpu utilization | +4.93 | [+1.70, +8.15] | 1 | Logs |
➖ | otlp_ingest_logs | memory utilization | +0.17 | [+0.04, +0.29] | 1 | Logs |
➖ | file_tree | memory utilization | +0.11 | [+0.08, +0.15] | 1 | Logs |
➖ | quality_gate_idle | memory utilization | +0.07 | [+0.04, +0.11] | 1 | Logs bounds checks dashboard |
➖ | file_to_blackhole_100ms_latency | egress throughput | +0.07 | [-0.54, +0.67] | 1 | Logs |
➖ | file_to_blackhole_0ms_latency | egress throughput | +0.03 | [-0.55, +0.60] | 1 | Logs |
➖ | quality_gate_idle_all_features | memory utilization | +0.00 | [-0.03, +0.04] | 1 | Logs bounds checks dashboard |
➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.00 | [-0.02, +0.02] | 1 | Logs |
➖ | uds_dogstatsd_to_api | ingress throughput | -0.01 | [-0.28, +0.27] | 1 | Logs |
➖ | file_to_blackhole_1000ms_latency | egress throughput | -0.02 | [-0.62, +0.58] | 1 | Logs |
➖ | ddot_metrics | memory utilization | -0.02 | [-0.14, +0.10] | 1 | Logs |
➖ | ddot_logs | memory utilization | -0.09 | [-0.18, +0.00] | 1 | Logs |
➖ | file_to_blackhole_500ms_latency | egress throughput | -0.10 | [-0.71, +0.52] | 1 | Logs |
➖ | otlp_ingest_metrics | memory utilization | -0.20 | [-0.34, -0.06] | 1 | Logs |
➖ | uds_dogstatsd_20mb_12k_contexts_20_senders | memory utilization | -0.32 | [-0.36, -0.28] | 1 | Logs |
➖ | docker_containers_memory | memory utilization | -0.42 | [-0.51, -0.32] | 1 | Logs |
➖ | tcp_syslog_to_blackhole | ingress throughput | -0.95 | [-1.01, -0.89] | 1 | Logs |
➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | -1.88 | [-2.73, -1.03] | 1 | Logs |
➖ | quality_gate_logs | % cpu utilization | -2.15 | [-4.86, +0.57] | 1 | Logs bounds checks dashboard |
Bounds Checks: ✅ Passed
perf | experiment | bounds_check_name | replicates_passed | links |
---|---|---|---|---|
✅ | docker_containers_cpu | simple_check_run | 10/10 | |
✅ | docker_containers_memory | memory_usage | 10/10 | |
✅ | docker_containers_memory | simple_check_run | 10/10 | |
✅ | file_to_blackhole_0ms_latency | lost_bytes | 10/10 | |
✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_100ms_latency | lost_bytes | 10/10 | |
✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_500ms_latency | lost_bytes | 10/10 | |
✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | |
✅ | quality_gate_idle | intake_connections | 10/10 | bounds checks dashboard |
✅ | quality_gate_idle | memory_usage | 10/10 | bounds checks dashboard |
✅ | quality_gate_idle_all_features | intake_connections | 10/10 | bounds checks dashboard |
✅ | quality_gate_idle_all_features | memory_usage | 10/10 | bounds checks dashboard |
✅ | quality_gate_logs | intake_connections | 10/10 | bounds checks dashboard |
✅ | quality_gate_logs | lost_bytes | 10/10 | bounds checks dashboard |
✅ | quality_gate_logs | memory_usage | 10/10 | bounds checks dashboard |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
Static quality checks✅ Please find below the results from static quality gates Successful checksInfo
|
Backport a30b8e4 from #39175.
What does this PR do?
The dd-trace-go library depends on this package for its remote config repository implementation. It cannot parse updates to this product without it being listed as valid.
Motivation
We are working on symdb integration for Go DI.
Describe how you validated your changes
I combined this with #39174 and DataDog/dd-trace-go#3799 with some replace directives and then it all works.
Relates to https://datadoghq.atlassian.net/browse/DEBUG-4206