Skip to content

Remove python setup in github workflows #36642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 6, 2025
Merged

Conversation

pgimalac
Copy link
Member

@pgimalac pgimalac commented May 5, 2025

What does this PR do?

Backport #36150 to 7.65.x.

Motivation

Fix the CI.

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

@pgimalac pgimalac requested review from a team as code owners May 5, 2025 14:29
@pgimalac pgimalac removed the request for review from a team May 5, 2025 14:30
@pgimalac pgimalac added the qa/no-code-change No code change in Agent code requiring validation label May 5, 2025
@pgimalac pgimalac requested a review from truthbk May 5, 2025 14:30
@pgimalac pgimalac requested a review from jeremy-hanna May 5, 2025 14:30
@github-actions github-actions bot added the long review PR is complex, plan time to review it label May 5, 2025
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented May 5, 2025

[Fast Unit Tests Report]

On pipeline 64212052 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_deb-arm64-py3
  • tests_deb-x64-py3
  • tests_flavor_dogstatsd_deb-x64
  • tests_flavor_heroku_deb-x64
  • tests_flavor_iot_deb-x64
  • tests_rpm-arm64-py3
  • tests_rpm-x64-py3
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented May 5, 2025

Uncompressed package size comparison

Comparison with ancestor 59c87a0602587d6b02fbbcab5532699462369dfe

Size reduction summary
package diff status size ancestor threshold
datadog-agent-x86_64-rpm -0.72MB 815.52MB 816.25MB 0.50MB
datadog-agent-x86_64-suse -0.72MB 815.52MB 816.25MB 0.50MB
datadog-agent-aarch64-rpm -0.79MB 806.50MB 807.29MB 0.50MB
Diff per package
package diff status size ancestor threshold
datadog-agent-amd64-deb 0.18MB ⚠️ 806.62MB 806.44MB 0.50MB
datadog-heroku-agent-amd64-deb 0.13MB ⚠️ 442.01MB 441.88MB 0.50MB
datadog-agent-arm64-deb 0.11MB ⚠️ 797.62MB 797.51MB 0.50MB
datadog-iot-agent-x86_64-rpm 0.01MB ⚠️ 61.07MB 61.06MB 0.50MB
datadog-iot-agent-x86_64-suse 0.01MB ⚠️ 61.07MB 61.06MB 0.50MB
datadog-iot-agent-aarch64-rpm 0.01MB ⚠️ 58.37MB 58.35MB 0.50MB
datadog-iot-agent-amd64-deb 0.01MB ⚠️ 61.00MB 60.99MB 0.50MB
datadog-iot-agent-arm64-deb 0.01MB ⚠️ 58.29MB 58.28MB 0.50MB
datadog-dogstatsd-x86_64-rpm 0.01MB ⚠️ 39.44MB 39.43MB 0.50MB
datadog-dogstatsd-x86_64-suse 0.01MB ⚠️ 39.44MB 39.43MB 0.50MB
datadog-dogstatsd-amd64-deb 0.01MB ⚠️ 39.36MB 39.35MB 0.50MB
datadog-dogstatsd-arm64-deb 0.01MB ⚠️ 37.89MB 37.88MB 0.50MB

Decision

⚠️ Warning

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented May 5, 2025

Static quality checks ✅

Please find below the results from static quality gates

Successful checks

Info

Result Quality gate On disk size On disk size limit On wire size On wire size limit
static_quality_gate_agent_deb_amd64 779.43 MiB 801.8 MiB 189.71 MiB 202.62 MiB
static_quality_gate_agent_deb_arm64 770.82 MiB 793.14 MiB 172.76 MiB 184.51 MiB
static_quality_gate_agent_rpm_amd64 779.42 MiB 801.79 MiB 192.3 MiB 205.03 MiB
static_quality_gate_agent_rpm_arm64 770.81 MiB 793.09 MiB 173.41 MiB 186.44 MiB
static_quality_gate_agent_suse_amd64 779.42 MiB 801.81 MiB 192.3 MiB 205.03 MiB
static_quality_gate_agent_suse_arm64 770.81 MiB 793.14 MiB 173.41 MiB 186.44 MiB
static_quality_gate_dogstatsd_deb_amd64 37.61 MiB 47.67 MiB 9.75 MiB 19.78 MiB
static_quality_gate_dogstatsd_deb_arm64 36.21 MiB 46.27 MiB 8.46 MiB 18.49 MiB
static_quality_gate_dogstatsd_rpm_amd64 37.61 MiB 47.67 MiB 9.76 MiB 19.79 MiB
static_quality_gate_dogstatsd_suse_amd64 37.61 MiB 47.67 MiB 9.76 MiB 19.79 MiB
static_quality_gate_iot_agent_deb_amd64 58.25 MiB 69.0 MiB 14.72 MiB 24.8 MiB
static_quality_gate_iot_agent_deb_arm64 55.67 MiB 66.4 MiB 12.72 MiB 22.8 MiB
static_quality_gate_iot_agent_rpm_amd64 58.25 MiB 69.0 MiB 14.74 MiB 24.8 MiB
static_quality_gate_iot_agent_rpm_arm64 55.67 MiB 66.4 MiB 12.74 MiB 22.8 MiB
static_quality_gate_iot_agent_suse_amd64 58.25 MiB 69.0 MiB 14.74 MiB 24.8 MiB
static_quality_gate_docker_agent_amd64 864.53 MiB 886.12 MiB 290.37 MiB 304.21 MiB
static_quality_gate_docker_agent_arm64 879.21 MiB 900.79 MiB 276.82 MiB 290.47 MiB
static_quality_gate_docker_agent_jmx_amd64 1.04 GiB 1.06 GiB 365.47 MiB 379.33 MiB
static_quality_gate_docker_agent_jmx_arm64 1.04 GiB 1.06 GiB 347.92 MiB 361.55 MiB
static_quality_gate_docker_dogstatsd_amd64 45.75 MiB 55.78 MiB 17.26 MiB 27.28 MiB
static_quality_gate_docker_dogstatsd_arm64 44.39 MiB 54.45 MiB 16.13 MiB 26.16 MiB
static_quality_gate_docker_cluster_agent_amd64 262.12 MiB 274.78 MiB 104.77 MiB 116.28 MiB
static_quality_gate_docker_cluster_agent_arm64 278.07 MiB 290.82 MiB 99.61 MiB 111.12 MiB

Copy link

cit-pr-commenter bot commented May 6, 2025

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: a631a116-be29-4580-97e6-bdcc4101778b

Baseline: 44f7e70
Comparison: d29ea0a
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_idle_all_features memory utilization +0.37 [+0.29, +0.45] 1 Logs bounds checks dashboard
file_to_blackhole_1000ms_latency egress throughput +0.09 [-0.68, +0.85] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.04 [-0.74, +0.83] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput +0.02 [-0.79, +0.84] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.01 [-0.71, +0.74] 1 Logs
uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization +0.01 [-0.03, +0.05] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.00 [-0.81, +0.82] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.00 [-0.26, +0.27] 1 Logs
file_to_blackhole_300ms_latency egress throughput -0.00 [-0.64, +0.64] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.02 [-0.05, +0.00] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization -0.03 [-0.84, +0.79] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput -0.04 [-0.82, +0.75] 1 Logs
quality_gate_logs % cpu utilization -0.10 [-2.94, +2.73] 1 Logs
quality_gate_idle memory utilization -0.22 [-0.28, -0.17] 1 Logs bounds checks dashboard
tcp_syslog_to_blackhole ingress throughput -0.25 [-0.31, -0.18] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput -0.27 [-0.73, +0.20] 1 Logs
file_tree memory utilization -0.97 [-1.11, -0.82] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.

@Pythyu Pythyu merged commit cedfc43 into 7.65.x May 6, 2025
210 checks passed
@Pythyu Pythyu deleted the backport-36150-to-7.65.x branch May 6, 2025 15:40
@github-actions github-actions bot added this to the 7.65.1 milestone May 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog long review PR is complex, plan time to review it qa/no-code-change No code change in Agent code requiring validation team/agent-devx
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants