Skip to content

[DT-1641] Implement the DUOS Data Library Card #2864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 21, 2025

Conversation

PintoGideon
Copy link
Contributor

Addresses

https://broadworkbench.atlassian.net/browse/DT-1641

Summary

  • Replace the current "DUOS Overview" section on the homepage with a new "Data Libraries in DUOS" section featuring a three-column image layout that links to curated Data Library pages.
  • Horizontal layout for screens larger than 904 px. Switches to vertical layout on smaller screens.
  • MUI tooltips that display dataset names when the user hovers or focuses on the logos.

Screenshots:

Mobile (iPhone SE)

local dsde-dev broadinstitute org_3000_home(iPhone SE)

Laptop (XPS 13)

Screenshot From 2025-05-12 23-31-27


Have you read Terra's Contributing Guide lately? If not, do that first.

  • Label PR with a Jira ticket number and include a link to the ticket
  • Label PR with a security risk modifier [no, low, medium, high]
  • PR describes scope of changes
  • Get a minimum of one thumbs worth of review, preferably two if enough team members are available
  • Get PO sign-off for all non-trivial UI or workflow changes
  • Verify all tests go green
  • Test this change deployed correctly and works on dev environment after deployment

@PintoGideon PintoGideon requested a review from a team as a code owner May 13, 2025 03:51
@PintoGideon PintoGideon requested review from pshapiro4broad and fboulnois and removed request for a team May 13, 2025 03:51
Copy link
Contributor

@fboulnois fboulnois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, could we add some tests? Perhaps checking that the data library links now exist on the page, and maybe that the tooltips work?

Copy link
Contributor

@fboulnois fboulnois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my previous comment, otherwise looks good.

Copy link
Contributor

@rushtong rushtong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed that this component could use some tests. See comments inline, but nothing looks like a blocker, address as you see fit 👍🏽

@pshapiro4broad pshapiro4broad removed their request for review May 15, 2025 13:58
Copy link

Copy link
Contributor

@rushtong rushtong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the auto-sign-in solution 👍🏽

@PintoGideon PintoGideon merged commit ee9e706 into develop May 21, 2025
12 checks passed
@PintoGideon PintoGideon deleted the gp/dt-1641-replace-overview-page branch May 21, 2025 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants