-
Notifications
You must be signed in to change notification settings - Fork 4
[DT-1641] Implement the DUOS Data Library Card #2864
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, could we add some tests? Perhaps checking that the data library links now exist on the page, and maybe that the tooltips work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my previous comment, otherwise looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed that this component could use some tests. See comments inline, but nothing looks like a blocker, address as you see fit 👍🏽
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love the auto-sign-in solution 👍🏽
Addresses
https://broadworkbench.atlassian.net/browse/DT-1641
Summary
Screenshots:
Mobile (iPhone SE)
Laptop (XPS 13)
Have you read Terra's Contributing Guide lately? If not, do that first.