-
Notifications
You must be signed in to change notification settings - Fork 39
feat(copy): remove title/hideTooltip, add tooltip #479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,14 +1,32 @@ | ||
import React from 'react'; | ||
import { Copy } from 'dt-react-component'; | ||
import { Space } from 'antd'; | ||
import { BlockHeader, Copy } from 'dt-react-component'; | ||
|
||
const text = | ||
'基于 ant-design 的 React UI 组件库。 主要用于中,后台产品。我们的目标是满足更具体的业务场景组件。 当然,我们也有基于原生 javascript 实现的业务组件,例如ContextMenu,KeyEventListener等.'; | ||
|
||
export default () => { | ||
return ( | ||
<div> | ||
<Copy text={text} title="复制该文本" /> | ||
<p>{text}</p> | ||
</div> | ||
<Space direction="vertical"> | ||
<div> | ||
<BlockHeader title="使用 tooltip 对象" showBackground={false} size="small" /> | ||
<Copy text={text} tooltip={{ title: '使用 tooltip 对象,复制该文本' }} /> | ||
<p>{text}</p> | ||
</div> | ||
<div> | ||
<BlockHeader title="使用 React.ReactNode" showBackground={false} size="small" /> | ||
<Copy text={text} tooltip="使用 React.ReactNode,复制该文本" /> | ||
<p>{text}</p> | ||
</div> | ||
<div> | ||
<BlockHeader | ||
title={`使用 ()=>React.ReactNode`} | ||
showBackground={false} | ||
size="small" | ||
/> | ||
<Copy text={text} tooltip={() => `使用 ()=>React.ReactNode,复制该文本`} /> | ||
<p>{text}</p> | ||
</div> | ||
</Space> | ||
); | ||
}; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
import React from 'react'; | ||
import { TooltipProps } from 'antd'; | ||
|
||
export type LabelTooltipType = TooltipProps | TooltipProps['title']; | ||
|
||
export function toTooltipProps(tooltip: LabelTooltipType): TooltipProps | null { | ||
if (tooltip !== null && typeof tooltip === 'object' && !React.isValidElement(tooltip)) { | ||
return tooltip as TooltipProps; | ||
} | ||
return { | ||
title: tooltip, | ||
}; | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.