-
Notifications
You must be signed in to change notification settings - Fork 39
fix(modal): improve modal's size #452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuckyFBB
approved these changes
Mar 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
+1 |
目前修复最大高度用 Flex 来自适应来做,感觉不太保险。但是暂时没考虑到更好的方法。
各位觉得用哪种方式更好? |
title 的内容会不会多到需要换行,写死高度这时候就有点不合适了吧 |
first |
liuxy0551
approved these changes
Aug 23, 2024
LuckyFBB
reviewed
Aug 30, 2024
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
简介
Changes
由于项目内部引用了 theme,会去修改 font-base-size,导致 Modal 的 header 和 footer 的高度并不是正常高度,所以这里没办法通过写死高度来计算 body 的高度。目前通过 Flex 的自适应来达到限制最大高度 600px 的需求。