Share analysis graph code for submissions #2956
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code for the contest analysis was updated, but not yet for the problem analysis. As these graphs should behave the same, the code for creating the graph has been moved from twig to static JavaScript and only the data is rendered in twig. This simplifies sharing the graph creation code and slightly reduces server rendering load.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code for the contest analysis was updated in #2944, but not yet for the problem analysis. As these graphs should behave the same, the code for creating the graph has been moved from twig to static JavaScript and only the data is rendered in twig. This simplifies sharing the graph creation code and slightly reduces server rendering load.
Smaller problem-submission graph:
