don't assume order of nldi sources -- turn nldi tests back on but off in CI #774
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dblodgett-usgs
had a problem deploying
to
github-pages
GitHub Actions
Failure
|
So....do we add dplyr as a import for this change? I went through some effort many years ago to get rid of it as a dependency because a few squeeky wheels were so anti-dplyr at the time, and it wasn't adding much. We already Suggest it, so it's not the end of the world. |
|
Oh -- do you know import dplyr? I had no idea. I'll implement an alternate solution. Sorry about that. |
|
Looks like I don't actually need bind_rows(). |
dblodgett-usgs
had a problem deploying
to
github-pages
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a new version of the NLDI coming and this is the only issue I see where the new one doesn't work with dataRetrieval. This change is backward compatible.