Fix memory leak in VecVideoRecorder by properly deleting references #2176
+36
−32
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a memory leak in
VecVideoRecorder
whererecorded_frames
stayed in memory due to references held by the MoviePy clip object. The fix applies the same solution as implemented in Farama-Foundation/Gymnasium#1444.Problem
When
VecVideoRecorder
stops recording and saves a video, therecorded_frames
list would remain in memory because MoviePy'sImageSequenceClip
maintains references to the frame data even after the video is written. This caused a memory leak during long training sessions with video recording enabled.Solution
Added explicit
del
statements in the_stop_recording()
method to properly clean up references:The fix ensures that:
clip
object is explicitly deleted after video writingrecorded_frames
list is deleted before assigning a new empty listTesting
recorded_frames
are properly cleared after video savesThis change is backward compatible and only affects the internal memory management of the video recorder.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.