Skip to content

Discard delimiters inside double quote #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

0x546F6D
Copy link
Contributor

I needed this functionality for my personal use-cases, not sure if necessary for anyone else.

@DISTREAT DISTREAT self-requested a review January 11, 2025 00:13
@DISTREAT DISTREAT added the enhancement New feature or request label Jan 11, 2025
@DISTREAT
Copy link
Owner

Hey there, I apologize for the late response and should not have left you unread for I appreciate the contribution.

Before I am able to consider your changes I need to reevaluate the project's direction since CSV parsers tend to handle edge cases vastly different, including how they treat quotation.

Furthermore, I was finally able to find the motivation to draft a direction and need to outline my thoughts before getting back to you.

Not sure how interested you are in continuing to add to this branch because otherwise I would just try my best to somehow incorporate your changes and build around your initial scope.

Cheers

@0x546F6D
Copy link
Contributor Author

Hi, if you give me a few weeks, I can probably find the time to look into it once again, maybe after 0.15 get released.
I made those changes when I was barely starting to learn Zig so it might not be the most optimal code :)
In any case, I will convert this PR into draft now so u can already work on it.

@0x546F6D 0x546F6D marked this pull request as draft July 21, 2025 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants