Skip to content

Persons API #554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Aug 8, 2024
Merged

Persons API #554

merged 17 commits into from
Aug 8, 2024

Conversation

FrostyApeOne
Copy link
Collaborator

The following have been implemented however still WIP

  • Persons API project created
  • Generic repository added to reduce boiler plating
  • AutoMapper added to ease mapping, improve performance and stick to SOLID principles

elielijah321 and others added 11 commits August 2, 2024 11:56
@elielijah321
Set un draft endpoint
42c53cb
@elielijah321
get-mp-from-constituency
2e2ad31
@DrizzlyOwl
Add devops for new Person API (#551)
d5b4427 
* Basic dockerfile for serving the Person API

* Custom entrypoint script that does not run any EF migrations

* Add new Person Api Dockerfile to build test

* Add new Project to .NET CI tests

* Fix: target correct project during build

* CI: Test both Dockerfiles
@elielijah321
add integration test
1610030
@elielijah321
Merge branch 'feature/173197-Persons-API' of https://github.com/DFE-D…
b3b85db 
…igital/academies-api into feature/173197-Persons-API
Added Generic Repository and AutoMapper
7afc471
Merge branch 'feature/173197-Persons-API' of https://github.com/DFE-D…
f20e2b8 
…igital/academies-api into feature/173197-Persons-API
@DrizzlyOwl
Build and deploy Persons API (#552)
fe05649 
* Adjust deployment workflow to include the Persons Api

* Deploy a Custom Container App using Terraform
General refactoring
904c175
Merge branch 'feature/173197-Persons-API' of https://github.com/DFE-D…
4fd229d 
…igital/academies-api into feature/173197-Persons-API
@DrizzlyOwl
add tag prefix to docker build stage (#553)
e367637 
* prefix tags when built on GHCR so that persons api is distinct from academies api
github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 8, 2024
View reviewed changes
DrizzlyOwl
DrizzlyOwl requested changes Aug 8, 2024
View reviewed changes
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Aug 8, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot
0.0% Coverage on New Code (required ≥ 70%)
28.5% Duplication on New Code (required ≤ 3.0%)
74 New Code Smells (required ≤ 0)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

DrizzlyOwl
DrizzlyOwl approved these changes Aug 8, 2024
View reviewed changes
Copy link
Collaborator

@DrizzlyOwl DrizzlyOwl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to approve considering other changes are minimal impact and can be addressed later

@FrostyApeOne FrostyApeOne merged commit ff48d57 into main Aug 8, 2024
4 of 5 checks passed
@FrostyApeOne FrostyApeOne deleted the feature/173197-Persons-API branch August 8, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DrizzlyOwl DrizzlyOwl DrizzlyOwl approved these changes

@elielijah321 elielijah321 Awaiting requested review from elielijah321

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FrostyApeOne @DrizzlyOwl @elielijah321