Skip to content

Hotfix string interpolation on logging for v4 establishments endpoints #539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 22, 2024
Merged

Hotfix string interpolation on logging for v4 establishments endpoints #539

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions TramsDataApi/Controllers/V4/EstablishmentsController.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
using System.Text.Json;
using System.Threading;
using System.Threading.Tasks;
using Azure.Core;
using Dfe.Academies.Application.Establishment;
using Dfe.Academies.Contracts.V4.Establishments;
using Microsoft.AspNetCore.Mvc;
Expand Down Expand Up @@ -98,14 +99,14 @@ public async Task<ActionResult<EstablishmentDto>> GetEstablishmentByUrn(string u
public async Task<ActionResult<List<EstablishmentDto>>> SearchEstablishments(string name, string ukPrn, string urn, CancellationToken cancellationToken)
{
_logger.LogInformation(
"Searching for establishments by name \"{name}\", UKPRN \"{prn}\", urn \"{number}\"}",
"Searching for establishments by name \"{name}\", UKPRN \"{ukPrn}\", urn \"{number}\"",
name, ukPrn, urn);

var (establishments, recordCount) = await _establishmentQueries
.Search(name, ukPrn, urn, cancellationToken).ConfigureAwait(false);

_logger.LogInformation(
"Found {count} establishments for name \"{name}\", UKPRN \"{prn}\", urn \"{number}\"",
"Found {count} establishments for name \"{name}\", UKPRN \"{ukPrn}\", urn \"{number}\"",
recordCount, name, ukPrn, urn);

_logger.LogDebug(JsonSerializer.Serialize(establishments));
Expand All @@ -127,8 +128,8 @@ public async Task<ActionResult<List<EstablishmentDto>>> SearchEstablishments(str
[SwaggerResponse(404, "No establishments found for specified regions.")]
public async Task<ActionResult<IEnumerable<int>>> GetURNsByRegion([FromQuery] string[] regions, CancellationToken cancellationToken)
{
_logger.LogInformation(
"Searching for establishment URNs by regions\"{regions}\"}",
_logger.LogInformation(
"Searching for establishment URNs by regions\"{regions}\"",
regions);

var establishmentURNs = await _establishmentQueries
Expand Down
Loading