-
Notifications
You must be signed in to change notification settings - Fork 5
Enforce eslint and prettier rules with a pre-commit hook #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tpadjen
wants to merge
7
commits into
DEVxNetwork:master
Choose a base branch
from
tpadjen:lint-staged
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
fa17fac
Run eslint and prettier on a pre-commit hook
tpadjen 11872bd
Add jsx to lint-staged watch file types
tpadjen 9ad5121
Ignore eslint cache file
tpadjen c038a8a
Separate communty deescription paragraph to avoid escaping quotes wit…
tpadjen 8417c80
Allow standard img tags
tpadjen 776b672
Add suggested img alt descriptions for logos and hero
tpadjen 36ba098
Remove eslint warnings for standard default exports of config objects
tpadjen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,12 @@ | ||
{ | ||
"extends": "next/core-web-vitals" | ||
"extends": "next/core-web-vitals", | ||
"rules": { | ||
"@next/next/no-img-element": "off", | ||
"import/no-anonymous-default-export": [ | ||
"warn", | ||
{ | ||
"allowObject": true | ||
} | ||
] | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -35,5 +35,8 @@ yarn-error.log* | |
*.tsbuildinfo | ||
next-env.d.ts | ||
|
||
# nova | ||
.nova | ||
# nova | ||
.nova | ||
|
||
# eslint | ||
.eslintcache |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
_ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
#!/bin/sh | ||
. "$(dirname "$0")/_/husky.sh" | ||
|
||
npx lint-staged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,18 @@ | ||
import React from "react" | ||
|
||
const communityDescription = ` | ||
We're a community of developers of all skill levels, dedicated to fostering a fun and | ||
educational environment. Hosted by Sam Holmes and a team of passionate organizers, our | ||
monthly meetups offer an opportunity to network, learn, and showcase your projects. At | ||
each event, you'll enjoy complimentary food and drinks during our networking lunch, | ||
followed by a series of engaging presentations on various developer and engineering | ||
topics. After the talks, we break into groups for casual networking, project showcases, | ||
and coding help. Whether you're a seasoned developer or just starting out, there's | ||
something for everyone. Be sure to bring your laptop if you'd like to share your latest | ||
project or give a presentation. We look forward to meeting you and seeing what you're | ||
excited about! | ||
` | ||
Comment on lines
+3
to
+14
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think I resolved this same issue in my PR, but instead of factoring out the string, I kept it inline. That'd be preferable since this consts is single-use. |
||
|
||
export default function About() { | ||
return ( | ||
<main className="p-8 bg-gray-900 min-h-screen text-white"> | ||
|
@@ -13,19 +26,7 @@ export default function About() { | |
<section className="bg-gray-800 p-8 rounded-lg shadow-md mb-12"> | ||
<h2 className="text-3xl font-bold mb-4 text-center">About us</h2> | ||
<div className="w-full flex justify-center"> | ||
<p className="mt-2 text-xl text-center max-w-screen-lg"> | ||
{" "} | ||
We're a community of developers of all skill levels, dedicated to fostering a fun and | ||
educational environment. Hosted by Sam Holmes and a team of passionate organizers, our | ||
monthly meetups offer an opportunity to network, learn, and showcase your projects. At | ||
each event, you'll enjoy complimentary food and drinks during our networking lunch, | ||
followed by a series of engaging presentations on various developer and engineering | ||
topics. After the talks, we break into groups for casual networking, project showcases, | ||
and coding help. Whether you're a seasoned developer or just starting out, there's | ||
something for everyone. Be sure to bring your laptop if you'd like to share your latest | ||
project or give a presentation. We look forward to meeting you and seeing what you're | ||
excited about! | ||
</p> | ||
<p className="mt-2 text-xl text-center max-w-screen-lg">{communityDescription}</p> | ||
</div> | ||
</section> | ||
|
||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm unsure what this fixes.