Fix: AsObservable immediately calls Dispose on completion #331
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As pointed out in #330, when using
AsObservable()
in combination with message-delaying operators such asDelay
orObserveOn
, the OnCompleted signal was not properly propagated downstream.The cause was that
WrappedObserver
is defined withAutoDisposeOnCompleted = true
, andAsObservable()
uses it as-is.As a fix,
AsObservable()
now uses a dedicated observer.A similar issue was also present in
AsSystemObservable()
, so it has been fixed as well.