force continuations to run async #325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

JaggerJo wants to merge 1 commit into Cysharp:main from JaggerJo:fix-task-completion-source-sync-continuation

JaggerJo commented Apr 16, 2025 •

edited

Loading

I noticed that TaskObserverBase internally uses a TaskCompletionSource without passing TaskCreationOptions.RunContinuationsAsynchronously.

https://devblogs.microsoft.com/premier-developer/the-danger-of-taskcompletionsourcet-class/

https://github.com/davidfowl/AspNetCoreDiagnosticScenarios/blob/master/AsyncGuidance.md#always-create-taskcompletionsourcet-with-taskcreationoptionsruncontinuationsasynchronously


          force continuations to run async

72bd64c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet