Skip to content

Add support for state in Defer factory method #320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion docs/reference_factory.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,8 @@
| **CreateFrom**(`Func<CancellationToken, IAsyncEnumerable<T>>` factory) | `Observable<T>` |
| **CreateFrom**(`TState` state, `Func<CancellationToken, TState, IAsyncEnumerable<T>>` factory) | `Observable<T>` |
| **Defer**(`Func<Observable<T>>` observableFactory, `Boolean` rawObserver = false) | `Observable<T>` |
| **Empty**() | `Observable<T>` |
| **Defer**(`TState` state, `Func<TState, Observable<T>>` observableFactory, `Boolean` rawObserver = false) | `Observable<T>` |
| **Empty**() | `Observable<T>` |
| **Empty**(`TimeProvider` timeProvider) | `Observable<T>` |
| **Empty**(`TimeSpan` dueTime, `TimeProvider` timeProvider) | `Observable<T>` |
| **EveryUpdate**() | `Observable<Unit>` |
Expand Down
24 changes: 24 additions & 0 deletions src/R3/Factories/Defer.cs
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,11 @@ public static Observable<T> Defer<T>(Func<Observable<T>> observableFactory, bool
{
return new Defer<T>(observableFactory, rawObserver);
}

public static Observable<T> Defer<T, TState>(TState state, Func<TState, Observable<T>> observableFactory, bool rawObserver = false)
{
return new Defer<T, TState>(state, observableFactory, rawObserver);
}
}

internal sealed class Defer<T>(Func<Observable<T>> observableFactory, bool rawObserver) : Observable<T>
Expand All @@ -26,3 +31,22 @@ protected override IDisposable SubscribeCore(Observer<T> observer)
return observable.Subscribe(rawObserver ? observer : observer.Wrap());
}
}

internal sealed class Defer<T, TState>(TState state, Func<TState, Observable<T>> observableFactory, bool rawObserver) : Observable<T>
{
protected override IDisposable SubscribeCore(Observer<T> observer)
{
var observable = default(Observable<T>);
try
{
observable = observableFactory(state);
}
catch (Exception ex)
{
observer.OnCompleted(ex); // when failed, return Completed(Error)
return Disposable.Empty;
}

return observable.Subscribe(rawObserver ? observer : observer.Wrap());
}
}