Added tab complete. #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CubitsDev
requested changes
Apr 22, 2022
src/main/java/network/palace/show/commands/ShowDebugCommand.java
Outdated
Show resolved
Hide resolved
src/main/java/network/palace/show/commands/show/ShowTabComplete.java
Outdated
Show resolved
Hide resolved
src/main/java/network/palace/show/commands/show/ShowTabComplete.java
Outdated
Show resolved
Hide resolved
Author
|
Alright @CubitsDev i removed a dupe filename check I noticed, but for your other requested changes I have left comments responding to them. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Show Subcommands:
/show listlist is tabcompleted/show startstart is tabcompleted, as well as all shows that arent currently running./show stopstop is tabcompleted, as well as all shows that are currently running.Showgen Subcommands:
/showgen setcornersetcorner is tabcompleted as well as the players current coords. Also, I added support to the command so you can use a standard coord format, rather thanx,y,zyou can now dox y z. Old is still supported for backwards compatibility though./showgen setinitialscenesetinitialscene is tabcompleted ./showgen generategenerate is tabcompleted, as well asfakeblockandbottom/top, but only if you start typing so both formats work.Other:
I also fixed an out-of-bounds exception when not proving a show name, and any unknown/incomplete commands return a default help message.
My only concern is when generating the tab completions for show start, it has to actually check for files, so it could cause lag. I tried to spam it and there were no issues, plus it's a staff-only command so I don't think it will be a problem.
This should be ready for review, but I will update you if I find any issues. Thanks!