update develop branch with all changes from main #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the outer loop of the shape is not closed
- enable polylines as mesh for IFCGRID, IFCGRIDAXIS - add bounds checks in TriangulateRevolution
make scaling by _geometryLoader.GetLinearScalingFactor() optional in GetFlatMesh. Alternative would be: make IfcGeometryProcessor::AddComposedMeshToFlatMesh public
…TESIANPOINT as geometric item IFCFACESURFACE, IFCEDGE and IFCCARTESIANPOINT are derived from IfcRepresentationItem, so they could appear as geometric item In IfcGeometryLoader::GetColor: add check for curveColour because it is optional
…o ThatOpen-main
- add number of output curve points in BSpline curves as parameter instead of a fixed number of 20. - add some checks in Nurbs::init() to prevent crashes in case the Nurbs surface is not well defined in the IFC model.
Without ordering, the lines are in a random order, which makes it hard to track issues in exported files
cylinder surface is not reliable enough, use simple triangulation
…() const add IFCCLOTHOID curve type in IfcGeometryLoader::ComputeCurve add function double IfcGeometryLoader::ReadCurveMeasureSelect() const initialize glm::dmat4 transformation = glm::dmat4(1.0); in struct IfcPlacedGeometry to avoid uninitialized variables In IfcGeometry::Normalize() add check if numPoints > 0, otherwise extents will be DBL_MAX/DBL_MIN
…fcLoader to prevent near infinite loop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.