This repository was archived by the owner on Jun 21, 2024. It is now read-only.
Upgrade to Support Ruby 3.1 and 3.2 #1
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- its upstream, html-pipeline, has since been changed a lot - we need to adjust so can support main app better, which will use Ruby 3.1
- use zeitwerk naming convention - modify test to follow new filter function setup
- ensure that the library is okay across all rails and ruby versions
bivanalhar
force-pushed
the
bivan/upgrade-ruby-3.1
branch
14 times, most recently
from
a8ec9cb to
6edb614
Compare
bivanalhar
changed the title
bivanalhar
force-pushed
the
bivan/upgrade-ruby-3.1
branch
from
6edb614 to
cc41a5a
Compare
- drop ruby 3.0 since html-pipeline only support ruby >= 3.1 - modify naming for VERSION for rouge_filter
bivanalhar
force-pushed
the
bivan/upgrade-ruby-3.1
branch
from
cc41a5a to
a7fac90
Compare
|
Dropping support of html-pipeline-rouge_filter and switching back to upstream recommendation to use HTML::Pipeline's built-in SyntaxHighlightFilter |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We updated the library to keep in line with the upstream branch. Also, we drop support for Ruby <= 3.0 since the upstream one only support Ruby 3.1 and above