-
Notifications
You must be signed in to change notification settings - Fork 0
👷 Add Ruby version 3.4 to CI grid #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Since it reached EOL at 2023-03-31 (cf https://www.ruby-lang.org/en/downloads/branches/)
Since 3.0 reached EOL 2024-04-23
And introduce AM 8.0.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @pimpin, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request updates the couchbase-orm
gem's dependencies by raising the minimum required Ruby version to 3.2 and the minimum Active Model version to 7.1. This change signals a move towards supporting more recent environments and potentially leveraging features available in newer Ruby and Active Model releases.
Highlights
- Minimum Ruby Version: Increased the minimum required Ruby version for the gem from 2.7 to 3.2.
- Active Model Dependency: Updated the minimum required Active Model dependency from
>= 5.2
to>= 7.1
. - Test Matrix Updates (Implied): Based on the description, the test matrix has been updated to remove older Ruby versions (2.7, 3.1) and add newer ones (3.4) to align with the new minimum requirement, although these changes are not visible in the provided patch.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configureGemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the couchbase-orm.gemspec
to require Ruby version >= 3.2.0
(previously >= 2.7.0
) and Active Model version >= 7.1
(previously >= 5.2
). These are significant updates that drop support for several older versions of Ruby and Active Model, constituting breaking changes for users of this gem. My review comments highlight the importance of clearly communicating these breaking changes in release notes and any relevant documentation. Additionally, given the magnitude of these dependency changes, consider if a major version bump for the couchbase-orm
gem itself (e.g., from 2.0.4
to 3.0.0
) is warranted to signal these breaking changes to your users, following semantic versioning principles.
Why ?
Ruby 3.4 has been released and we want to cover up to date setups.
HOW ?