feat(ui): add support for custom note share base url #386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
3 tasks
CorentinTh
requested changes
Jan 9, 2025
There was a problem hiding this comment.
Hi @panjd123
Thanks for the PR 🙏
Small changes :
No need to .replace the origin of the generated url, you can simply pass your noteConfig to the usecase in https://github.com/CorentinTh/enclosed/blob/main/packages/app-client/src/modules/notes/notes.usecases.ts#L17
Just add an argument to the encryptAndCreateNote function
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#387