-
Notifications
You must be signed in to change notification settings - Fork 350
update custody group count #9723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update custody group count #9723
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I'd keep old code, we don't need to reset it incomplete slot when the number was decreased. But it's a good point that we should keep logging on any change.
Also I'd add tests to clarify db.setFirstCustodyIncompleteSlot(
calls when oldgroupcount >, oldgroupcount <. oldgroupcount ==
...rc/main/java/tech/pegasys/teku/statetransition/datacolumns/DataColumnSidecarCustodyImpl.java
Show resolved
Hide resolved
All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
...rc/main/java/tech/pegasys/teku/statetransition/datacolumns/DataColumnSidecarCustodyImpl.java
Outdated
Show resolved
Hide resolved
...rc/main/java/tech/pegasys/teku/statetransition/datacolumns/DataColumnSidecarCustodyImpl.java
Outdated
Show resolved
Hide resolved
...est/java/tech/pegasys/teku/statetransition/datacolumns/DataColumnSidecarCustodyImplTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR Description
Fixed Issue(s)
#9468
#9469
Documentation
doc-change-required
label to this PR if updates are required.Changelog