Skip to content

Conversation

mehdi-aouadi
Copy link
Contributor

@mehdi-aouadi mehdi-aouadi commented Jul 29, 2025

PR Description

  • The custody group count doesn't need to be updated during non finalisation
  • The FirstCustodyIncompleteSlot should be update at each slot even when the custody group count doesn't change

Fixed Issue(s)

#9468
#9469

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

@mehdi-aouadi mehdi-aouadi self-assigned this Jul 29, 2025
@mehdi-aouadi mehdi-aouadi requested a review from zilm13 July 29, 2025 16:05
Copy link
Contributor

@zilm13 zilm13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I'd keep old code, we don't need to reset it incomplete slot when the number was decreased. But it's a good point that we should keep logging on any change.
Also I'd add tests to clarify db.setFirstCustodyIncompleteSlot( calls when oldgroupcount >, oldgroupcount <. oldgroupcount ==

@mehdi-aouadi mehdi-aouadi marked this pull request as ready for review July 31, 2025 08:58
@github-actions
Copy link

github-actions bot commented Jul 31, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@mehdi-aouadi
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@mehdi-aouadi mehdi-aouadi requested a review from zilm13 July 31, 2025 09:00
github-actions bot added a commit that referenced this pull request Jul 31, 2025
@mehdi-aouadi mehdi-aouadi requested a review from zilm13 August 4, 2025 09:06
cursor[bot]

This comment was marked as outdated.

Copy link
Contributor

@zilm13 zilm13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mehdi-aouadi mehdi-aouadi enabled auto-merge (squash) August 5, 2025 10:18
@mehdi-aouadi mehdi-aouadi merged commit b4bf2e3 into Consensys:master Aug 5, 2025
19 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants