Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It has been designed when spec where different. Now, the sampler also cover the custody requirements too (it is a super set)
Documentation
doc-change-required
label to this PR if updates are required.Changelog
Note
Removes
DasLongPollCustody
(and its tests) and updates wiring to useDataColumnSidecarCustodyImpl
directly in custody/by-root components.DasLongPollCustody
and itsSlotEventsChannel
subscription and timeout calculation.BeaconChainController
to useDataColumnSidecarCustodyImpl
directly forDataColumnSidecarByRootCustodyImpl
.DasLongPollCustodyTest
and related stubs/usages.Written by Cursor Bugbot for commit 90e4116. This will update automatically on new commits. Configure here.