Skip to content

Conversation

tbenr
Copy link
Contributor

@tbenr tbenr commented Oct 22, 2025

It has been designed when spec where different. Now, the sampler also cover the custody requirements too (it is a super set)

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

Note

Removes DasLongPollCustody (and its tests) and updates wiring to use DataColumnSidecarCustodyImpl directly in custody/by-root components.

  • DAS Custody:
    • Remove DasLongPollCustody and its SlotEventsChannel subscription and timeout calculation.
    • Update BeaconChainController to use DataColumnSidecarCustodyImpl directly for DataColumnSidecarByRootCustodyImpl.
  • Tests:
    • Delete DasLongPollCustodyTest and related stubs/usages.

Written by Cursor Bugbot for commit 90e4116. This will update automatically on new commits. Configure here.

Copy link
Contributor

@zilm13 zilm13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants