-
Notifications
You must be signed in to change notification settings - Fork 350
Implement retrieving PTC duties + PayloadAttestationPool skeleton #10043
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
StefanBratanov
wants to merge
8
commits into
Consensys:master
Choose a base branch
from
StefanBratanov:get_ptc_duties
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+788
−42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fa28ebf
to
ae95f9d
Compare
ae95f9d
to
e0cb365
Compare
...c/main/java/tech/pegasys/teku/statetransition/payloadattestation/PayloadAttestationPool.java
Fixed
Show fixed
Hide fixed
PayloadAttestationMessage payloadAttestationMessage, Optional<UInt64> arrivalTimestamp); | ||
|
||
SszList<PayloadAttestation> getPayloadAttestationsForBlock( | ||
BeaconState blockSlotState, Bytes32 parentRoot); |
Check notice
Code scanning / CodeQL
Useless parameter
The parameter 'parentRoot' is never used.
cb1a3b0
to
ea0354a
Compare
ea0354a
to
3220c7f
Compare
Bug: Epoch Mismatch in Duty CalculationThe |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Add the necessary methods to implement for the Payload timeliness attestation duty
This PR implements
getPtcDuties
as a start and addsPayloadAttestationPool
which is to be implemented in future PRs. Also changed theBlockOperationSelectorFactory
to use the pool as well as handle gossip for payload attestations to be redirected to the pool. Also add publishing of the payload attestation message when added locally.Fixed Issue(s)
related to #10041
Documentation
doc-change-required
label to this PR if updates are required.Changelog
Note
Implements PTC duties retrieval and scaffolds payload attestation pooling with gossip integration across block production, APIs, spec utilities, networking, metrics, and tests.
getPtcDuties
with state/epoch validation and new JSON types (PtcDuties
,PtcDuty
).createPayloadAttestationData
andsendPayloadAttestationMessages
endpoints; extend metrics labels.Spec.getPtcAssignment
,getValidatorIndexToPtcAssignmentMap
; base stubs inValidatorsUtil
, Gloas impl inValidatorsUtilGloas
.RestApiConstants.DEPENDENT_ROOT
in attester duties JSON.PayloadAttestationMessage
publish path inEth2P2PNetwork
,ActiveEth2P2PNetwork
, andGossipForkManager
.PayloadAttestationPool
(NOOP +AggregatingPayloadAttestationPool
) andPayloadAttestationMessageValidator
.BeaconChainController
(init, gossip processing, local publish).BlockOperationSelectorFactory
now sources payload attestations from the pool (tests updated;BeaconBlockBodyLists.createPayloadAttestations
).getPtcDuties
).Written by Cursor Bugbot for commit 3220c7f. This will update automatically on new commits. Configure here.