Skip to content

Conversation

lucassaldanha
Copy link
Member

@lucassaldanha lucassaldanha commented Oct 21, 2025

PR Description

We don't need it... I think... :)

Fixed Issue(s)

N/A

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

Note

Removes Vert.x (and Reactor) from builds and code, updates license/versions configs, and simplifies node shutdown.

  • Dependencies:
    • Remove io.vertx:* from infrastructure/metrics, teku, and gradle/versions.gradle.
    • Remove io.projectreactor:reactor-core from networking/p2p and gradle/versions.gradle.
  • Core:
    • In tech.pegasys.teku.AbstractNode, remove Vert.x usage (field, import) and the shutdown call thenRun(vertx::close).
  • Build/Config:
    • Drop -Dvertx.disableFileCPResolving=true from applicationDefaultJvmArgs in build.gradle.
    • Remove io.vertx from gradle/license-report-config/allowed-licenses.json.

Written by Cursor Bugbot for commit 33a3edd. This will update automatically on new commits. Configure here.

@lucassaldanha lucassaldanha added the DO NOT MERGE Not ready to merge label Oct 21, 2025
@StefanBratanov
Copy link
Contributor

I agree we don't need it I am fairly sure.

@lucassaldanha lucassaldanha marked this pull request as ready for review October 21, 2025 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DO NOT MERGE Not ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants