[Stateless Proto] Add flag to set execution proof generation artificial delay #10027
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
…port any milestone Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
# Conflicts: # ethereum/spec/src/main/java/tech/pegasys/teku/spec/schemas/registry/SchemaRegistryBuilder.java
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
# Conflicts: # teku/src/test/java/tech/pegasys/teku/cli/options/ZkChainOptionsTest.java
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
…class Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
… validated proofs map Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
# Conflicts: # ethereum/statetransition/src/main/java/tech/pegasys/teku/statetransition/executionproofs/ExecutionProofManagerImpl.java
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
2 tasks
gfukushima
changed the title
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
# Conflicts: # ethereum/statetransition/src/main/java/tech/pegasys/teku/statetransition/executionproofs/ExecutionProofGenerator.java # ethereum/statetransition/src/main/java/tech/pegasys/teku/statetransition/executionproofs/ExecutionProofGeneratorImpl.java # ethereum/statetransition/src/main/java/tech/pegasys/teku/statetransition/executionproofs/ExecutionProofManagerImpl.java # ethereum/statetransition/src/test/java/tech/pegasys/teku/statetransition/executionproofs/ExecutionProofGeneratorImplTest.java # services/beaconchain/src/main/java/tech/pegasys/teku/services/beaconchain/BeaconChainController.java # services/zkchain/src/main/java/tech/pegasys/teku/services/zkchain/ZkChainConfiguration.java # teku/src/test/java/tech/pegasys/teku/cli/options/ZkChainOptionsTest.java
…' into add-flag-for-EP-generation-delay
rolfyone
reviewed
Oct 19, 2025
| public static final boolean DEFAULT_STATELESS_VALIDATION_ENABLED = false; | ||
| public static final boolean DEFAULT_GENERATE_EXECUTION_PROOFS_ENABLED = false; | ||
| public static final int DEFAULT_STATELESS_MIN_PROOFS_REQUIRED = 1; | ||
| public static final Duration DEFAULT_PROOF_GENERATION_DELAY = Duration.ofSeconds(2); |
There was a problem hiding this comment.
given everything is moving to millis, i'd probably take millis here, it'll allow you less than a second delay...
rolfyone
reviewed
Oct 19, 2025
Comment on lines
+58
to
+59
| private long statelessProofGenerationDelay = | ||
| ZkChainConfiguration.DEFAULT_PROOF_GENERATION_DELAY.toMillis(); |
There was a problem hiding this comment.
along the same lines, we've got millis here, seconds other places, so being consistent will make it easier to understand.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Adds a flag to enable custom artificial delay when generating the proofs, built on top of #10004
Fixed Issue(s)
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog
Note
Adds a CLI option to configure artificial execution-proof generation delay and wires it through config, manager, and generator.
--Xstateless-proofs-generation-delayoption; plumb toZkChainConfigurationasDuration proofDelayDurationInMswith default2s.BeaconChainControllerpasses configured delay toExecutionProofManagerImpl.ExecutionProofGenerator.generateExecutionProofto acceptDuration proofGenerationDelayand sleep for that duration.ExecutionProofManagerImplstores the delay and forwards it when generating proofs; minor cleanup in validation loop.Duration.ofMillis(0).Written by Cursor Bugbot for commit ea1c2ef. This will update automatically on new commits. Configure here.