Add ExecutionPayloadManager and implement ExecutionPayloadPublisher
#10017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...rc/main/java/tech/pegasys/teku/statetransition/execution/DefaultExecutionPayloadManager.java
Dismissed
Show dismissed
Hide dismissed
| /** Import an execution payload to the store. */ | ||
| public SafeFuture<ExecutionPayloadImportResult> onExecutionPayload( | ||
| final SignedExecutionPayloadEnvelope signedEnvelope, | ||
| final ExecutionLayerChannel executionLayer) { |
Check notice
Code scanning / CodeQL
Useless parameter Note
|
|
||
| // TODO-GLOAS: https://github.com/Consensys/teku/issues/9960 | ||
| public SafeFuture<InternalValidationResult> validate( | ||
| final SignedExecutionPayloadEnvelope signedEnvelope) { |
Check notice
Code scanning / CodeQL
Useless parameter Note
StefanBratanov
force-pushed
the
gloas_plumbing_execution_payload
branch
5 times, most recently
from
87518ee to
8be297c
Compare
StefanBratanov
force-pushed
the
gloas_plumbing_execution_payload
branch
from
8be297c to
3916f54
Compare
tbenr
approved these changes
Oct 22, 2025
...n/java/tech/pegasys/teku/validator/coordinator/publisher/ExecutionPayloadPublisherGloas.java
Outdated
Show resolved
Hide resolved
| // https://github.com/Consensys/teku/issues/9878 | ||
| case REJECT, SAVE_FOR_FUTURE, IGNORE -> {} | ||
| } | ||
| }); |
There was a problem hiding this comment.
I think we should terminate with a finish here and remove @SuppressWarnings("FutureReturnValueIgnored") (applies to BlockManager too)
There was a problem hiding this comment.
but yeah, that duplicates the noise in case of failing future...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
ExecutionPayloadManagerwhich is responsible as a delegator for validating and importing an execution payloadonExecutionPayloadhandler in ForkChoice which is unimplementedExecutionPayloadGossipChannelExecutionPayloadPublisherwhich is pretty basic. The interfaces and return types can be all changed once we get deeper into the implementation.ExecutionPayloadimportResultsimilar toBlockResultGossipForkManager.publishDataColumnSidecarFixed Issue(s)
related to #10008
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog
Note
Adds ExecutionPayloadManager and end-to-end wiring to gossip, publish, and import Gloas execution payloads with new result types and logging.
ExecutionPayloadManager(default + NOOP) withvalidateAndImportExecutionPayload/importExecutionPayload; introduceExecutionPayloadImportResult(+ success/failed implementations).ForkChoice.onExecutionPayload(...)(stub success) used by the manager.SignedExecutionPayloadEnvelope.toLogString()andLogFormatter.formatExecutionPayload(...).ExecutionPayloadGossipChanneland integrate withActiveEth2P2PNetworkstartup subscription.ExecutionPayloadGossipManager(publish returnsSafeFuture),GossipForkManagerandGossipForkSubscriptions*to publish execution payloads with feedback.ExecutionPayloadPublisherGloasto gossip payloads and data column sidecars then import via manager.ExecutionPayloadManager(incl.ExecutionPayloadGossipValidatorplaceholder); wire gossip processor tovalidateAndImportExecutionPayload; pass gossip channel and manager toExecutionPayloadPublisherGloas.DefaultExecutionPayloadManagerandExecutionPayloadPublisherGloas.publishDataColumnSidecarinGossipForkManager.Written by Cursor Bugbot for commit 07817bf. This will update automatically on new commits. Configure here.