COR-1651: Add touch kernel method
#1441
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm currently trying to test this with a local node and see whether it also resolves COR-1650 (empty deny list blocking transfer). |
|
Tested this locally and this works as expected. |
|
I can also not reproduce COR-1650 with this change anymore. Transfers will work with empty deny lists for when only deny lists are enabled. Transfers will also work if allow and deny lists are enabled and the receiver is on the allow list and it's deny list is empty. |
td202
approved these changes
Jul 24, 2025
concordium-consensus/src/Concordium/GlobalState/Persistent/BlockState.hs
Outdated
Show resolved
Hide resolved
added 5 commits
July 24, 2025 18:50
Adds definitions and implementation of the `touchTokenAccount` operation in the token kernel and the block state operations. The interface in the kernel is ``` touch :: PLTAccount m -> m Bool ``` The return value indicates whether the account already had a token balance associated (False) or if a zero account balance was newly created (True).
Added a new function `updateTokenAccountState` to Persistent/Account.hs that deals with updating the token account state table. The function is then used in Persistent/BlockState.hs abstractions for the persistent account versions.
td202
approved these changes
Jul 28, 2025
concordium-consensus/src/Concordium/GlobalState/Persistent/Account.hs
Outdated
Show resolved
Hide resolved
concordium-consensus/src/Concordium/GlobalState/Persistent/Account.hs
Outdated
Show resolved
Hide resolved
…ount.hs Co-authored-by: Thomas Dinsdale-Young <td202@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Introduce
touchkernel method.Changes
touchkernel methodbsoTouchTokenAccountmethodChecklist
hard-to-understand areas.
CLA acceptance
_Remove if not applicable.
By submitting the contribution I accept the terms and conditions of the
Contributor License Agreement v1.0
link: https://developers.concordium.com/CLAs/Contributor-License-Agreement-v1.0.pdf
I accept the above linked CLA.