Skip to content

Non-active members are not required to complete a major project #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

stevenmirabito
Copy link
Collaborator

@stevenmirabito stevenmirabito commented Jan 21, 2018

As the title suggests, this prevents members who are not active from submitting the major project form.

@liam-middlebrook
Copy link
Member

Why remove the option for a member who isn’t active to submit if they wish to have a project they’re working on evaluated?

@stevenmirabito
Copy link
Collaborator Author

stevenmirabito commented Jan 21, 2018

Because it's a waste of Eboard's time to evaluate membership requirements for people who do not have to complete said requirement. I would instead suggest they submit their code to http://csh.review

@mbillow
Copy link
Member

mbillow commented Jan 21, 2018

I have seen it abused a lot. There is no need to have Eboard review a major project not required for an evaluation.

@devinmatte
Copy link
Member

From what I understand there is historical instances of alumni submitting major projects. I don't think we should discourage that, however they don't need to do so through the conditional form if they actually want to pass a major project. So I see this change as good, as long as, if an alumni actually wishes to pass a major project, that EBoard hears them out.

@liam-middlebrook
Copy link
Member

I can understand that reasoning and I’m always happy to see people encourage use of http://csh.review

I do feel it’s important to note that csh.review isn’t about whether or not something makes the cut. It focuses more on providing feedback so the developer can improve on their project and in turn their own skills. That’s not necessarily what I see happening during the evaluation of major projects, so perhaps non active members who submit them are looking for something else.

@mbillow
Copy link
Member

mbillow commented Jan 21, 2018

I agree they are looking for something else, but whatever that something is I don’t think it is productive or useful. Who cares if Eboard approves of your projects if you aren’t an active member? It isn’t any of their roles to evaluate non-member projects.

@liam-middlebrook
Copy link
Member

FWIW this change looks fine to me. I’d prefer you take Marc’s suggestion about avoiding nesting before submitting but it’s fine without it.

I’m against the idea of evaluations processes which are handled by conditional happening outside of conditional. If you’re going to cite the constitution and say only active members can submit major projects that must be acknowledged by eboard that’s fine, but the stance should be consistent and not allow a side-channel for submitting major projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants