Merge pull request #224 from ComputerScienceHouse/co_op_student

Only allow current students to list co-ops

Author: devinmatte

conditional/blueprints/co_op.py

@@ -5,7 +5,7 @@
 from conditional.models.models import CurrentCoops
 from conditional.util.auth import get_user
 from conditional.util.flask import render_template
-from conditional.util.ldap import ldap_is_eval_director
+from conditional.util.ldap import ldap_is_eval_director, ldap_is_current_student
 from conditional.util.ldap import _ldap_add_member_to_group as ldap_add_member_to_group
 from conditional.util.ldap import _ldap_remove_member_from_group as ldap_remove_member_from_group
 from conditional.util.ldap import _ldap_is_member_of_group as ldap_is_member_of_group
@@ -42,6 +42,8 @@ def submit_co_op_form(user_dict=None):
     semester = post_data['semester']
     if post_data['semester'] not in valid_semesters:
         return "Invalid semester submitted", 400
+    if not ldap_is_current_student(user_dict['account']):
+        return "Must be current student", 403
 
     log.info('Submit {} Co-Op'.format(semester))
 

conditional/templates/nav.html

@@ -25,7 +25,9 @@
                     <a href="#" class="dropdown-toggle" data-toggle="dropdown" role="button" aria-haspopup="true" aria-expanded="false"><span class="glyphicon glyphicon-list-alt"></span> Forms <span class="caret"></span></a>
                     <ul class="dropdown-menu">
                         <li><a href="/major_project"><span class="glyphicon glyphicon-star"></span> Major Project</a></li>
+                        {% if student %}
                         <li><a href="/co_op"><span class="glyphicon glyphicon-briefcase"></span> Co-Op Submission</a></li>
+                        {% endif %}
                         {% if is_intromember %}
                         <li><a href="/intro_evals_form"><span class="glyphicon glyphicon-blackboard"></span> Introductory Evaluations</a></li>
                         {% endif %}