Skip to content

Commit 2ae75fc

Browse files
authored
Merge pull request #225 from ComputerScienceHouse/rit_username
Adding rit_username
2 parents 3f9fa48 + 1adabd9 commit 2ae75fc

File tree

3 files changed

+38
-5
lines changed

3 files changed

+38
-5
lines changed

conditional/blueprints/member_management.py

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
import io
33

44
from datetime import datetime
5-
from distutils.util import strtobool # pylint: disable=no-name-in-module,import-error
5+
from distutils.util import strtobool # pylint: disable=no-name-in-module,import-error
66

77
import structlog
88

@@ -71,14 +71,14 @@ def display_member_management(user_dict=None):
7171
onfloor_list = get_onfloor_members()
7272

7373
co_op_list = [(ldap_get_member(member.uid).displayName, member.semester, member.uid) \
74-
for member in CurrentCoops.query.filter(
74+
for member in CurrentCoops.query.filter(
7575
CurrentCoops.date_created > start_of_year(),
7676
CurrentCoops.semester != "Neither")]
7777

7878
freshmen = FreshmanAccount.query
7979
freshmen_list = []
8080

81-
for freshman_user in freshmen: # pylint: disable=not-an-iterable
81+
for freshman_user in freshmen: # pylint: disable=not-an-iterable
8282
freshmen_list.append({
8383
"id": freshman_user.id,
8484
"name": freshman_user.name,
@@ -217,8 +217,13 @@ def member_management_uploaduser(user_dict=None):
217217
else:
218218
room_number = None
219219

220+
if new_user[3]:
221+
rit_username = new_user[3]
222+
else:
223+
rit_username = None
224+
220225
log.info('Create Freshman Account for {} via CSV Upload'.format(name))
221-
db.session.add(FreshmanAccount(name, onfloor_status, room_number))
226+
db.session.add(FreshmanAccount(name, onfloor_status, room_number, rit_username))
222227

223228
db.session.flush()
224229
db.session.commit()

conditional/models/models.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,14 +16,16 @@ class FreshmanAccount(db.Model):
1616
onfloor_status = Column(Boolean)
1717
room_number = Column(String)
1818
signatures_missed = Column(Integer)
19+
rit_username = Column(String(10), nullable=True)
1920

20-
def __init__(self, name, onfloor, room=None, missed=None):
21+
def __init__(self, name, onfloor, room=None, missed=None, rit_username=None):
2122
self.name = name
2223
today = date.fromtimestamp(time.time())
2324
self.eval_date = today + timedelta(weeks=10)
2425
self.onfloor_status = onfloor
2526
self.room_number = room
2627
self.signatures_missed = missed
28+
self.rit_username = rit_username
2729

2830

2931
class FreshmanEvalData(db.Model):
Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,26 @@
1+
"""add_rit_username
2+
3+
Revision ID: 704962eabf9c
4+
Revises: d1a06ab54211
5+
Create Date: 2019-08-27 09:58:45.776217
6+
7+
"""
8+
9+
# revision identifiers, used by Alembic.
10+
revision = '704962eabf9c'
11+
down_revision = 'd1a06ab54211'
12+
13+
from alembic import op
14+
import sqlalchemy as sa
15+
16+
17+
def upgrade():
18+
# ### commands auto generated by Alembic - please adjust! ###
19+
op.add_column('freshman_accounts', sa.Column('rit_username', sa.String(length=10), nullable=True))
20+
# ### end Alembic commands ###
21+
22+
23+
def downgrade():
24+
# ### commands auto generated by Alembic - please adjust! ###
25+
op.drop_column('freshman_accounts', 'rit_username')
26+
# ### end Alembic commands ###

0 commit comments

Comments
 (0)