-
Notifications
You must be signed in to change notification settings - Fork 223
binning plugin examples #5414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
binning plugin examples #5414
Conversation
Thanks for your PR! I would recommend moving out the Larmor to its own function, similar to how it is done with espec. Then
|
@ikbuibui very good point - I missed that structure 😅 |
The CI job failed but there seems to be log file |
@ikbuibui You wanted to suggest some improvement regarding the global domain of the y-position in the Larmor radiation. What should I adjust? |
I will open a PR to get a correct relative particle position. This will be relative to the virtual particle which we use to calculate the moving window shift. The current method with using the global offset has jitter and is inaccurate (as described here). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some cleanup of internal comments required
share/picongpu/examples/BinningExamples/include/picongpu/param/binningSetup.param
Outdated
Show resolved
Hide resolved
share/picongpu/examples/BinningExamples/include/picongpu/param/binningSetup.param
Outdated
Show resolved
Hide resolved
share/picongpu/examples/BinningExamples/include/picongpu/param/binningSetup.param
Outdated
Show resolved
Hide resolved
share/picongpu/examples/BinningExamples/include/picongpu/param/binningSetup.param
Outdated
Show resolved
Hide resolved
share/picongpu/examples/BinningExamples/include/picongpu/param/binningSetup.param
Outdated
Show resolved
Hide resolved
share/picongpu/examples/BinningExamples/include/picongpu/param/binningSetup.param
Outdated
Show resolved
Hide resolved
a4985fa
to
b46fea7
Compare
b46fea7
to
63e97e6
Compare
This PR adds a collection of binning plugin use cased to the examples.