Skip to content

binning plugin examples #5414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: dev
Choose a base branch
from

Conversation

PrometheusPi
Copy link
Member

This PR adds a collection of binning plugin use cased to the examples.

@PrometheusPi PrometheusPi added this to the 0.9.0 / next stable milestone Jul 21, 2025
@PrometheusPi PrometheusPi requested a review from ikbuibui July 21, 2025 13:53
@PrometheusPi PrometheusPi added component: plugin in PIConGPU plugin documentation regarding documentation or wiki discussions labels Jul 21, 2025
@ikbuibui
Copy link
Contributor

Thanks for your PR! I would recommend moving out the Larmor to its own function, similar to how it is done with espec. Then getBinning would look like

{
  eSpec(binningCreator); 
  larmor(binningCreator);
}

@PrometheusPi
Copy link
Member Author

@ikbuibui very good point - I missed that structure 😅

@PrometheusPi
Copy link
Member Author

The CI job failed but there seems to be log file

@PrometheusPi
Copy link
Member Author

PrometheusPi commented Jul 23, 2025

@ikbuibui You wanted to suggest some improvement regarding the global domain of the y-position in the Larmor radiation. What should I adjust?

@ikbuibui
Copy link
Contributor

I will open a PR to get a correct relative particle position. This will be relative to the virtual particle which we use to calculate the moving window shift. The current method with using the global offset has jitter and is inaccurate (as described here).

Copy link
Contributor

@ikbuibui ikbuibui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some cleanup of internal comments required

@ikbuibui ikbuibui dismissed their stale review July 25, 2025 12:27

Changes added

@ikbuibui ikbuibui requested a review from psychocoderHPC July 25, 2025 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: plugin in PIConGPU plugin documentation regarding documentation or wiki discussions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants