Field binning fixes to pass fields and setters to configure binning #5402
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FieldInfo
which is how users are now supposed to pass fields to the binning plugin.This was necessary because users cant directly access the field data box from the binning setup. This is because binning setup is called on plugin load, and this happens before the fields are registered with the data connector.
The
FieldInfo
object is only passed to the binning functors AFTER being transformed to the corresponding field databox.Similarly, for passing field information when doing particle binning, passing a
FieldInfo
object as extra data will provide the user with access to the field databox.LOCAL_WITH_GUARDS
to be used withDomainInfo
, mainly with the view of making local field boxes correctly usable more easily. Added an example to the documentation which shows how to use field binning correctlygetParticlePosition
missing a cast, fixes cases where integral cell sizes are used