Skip to content

Field binning fixes to pass fields and setters to configure binning #5402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: dev
Choose a base branch
from

Conversation

ikbuibui
Copy link
Contributor

@ikbuibui ikbuibui commented Jun 30, 2025

  • Added a type called FieldInfo which is how users are now supposed to pass fields to the binning plugin.
    This was necessary because users cant directly access the field data box from the binning setup. This is because binning setup is called on plugin load, and this happens before the fields are registered with the data connector.
    The FieldInfo object is only passed to the binning functors AFTER being transformed to the corresponding field databox.
    Similarly, for passing field information when doing particle binning, passing a FieldInfo object as extra data will provide the user with access to the field databox.
  • Fixed setters of field binning data configuration not working (for example dump period)
  • Made the integer linear axis binning more robust against overflows by using 64 bit types internally (thanks @pordyna for testing an axis with almost a million bins)
  • Add a domain origin LOCAL_WITH_GUARDS to be used with DomainInfo, mainly with the view of making local field boxes correctly usable more easily. Added an example to the documentation which shows how to use field binning correctly
  • Fix getParticlePosition missing a cast, fixes cases where integral cell sizes are used

@ikbuibui ikbuibui added bug a bug in the project's code component: plugin in PIConGPU plugin labels Jun 30, 2025
@ikbuibui ikbuibui changed the title Dont get fields from data connector on plugin load Dont get fields from data connector on binning plugin load Jun 30, 2025
@ikbuibui ikbuibui changed the title Dont get fields from data connector on binning plugin load Field binning fixes to pass fields and setters to configure binning Jul 2, 2025
@ikbuibui ikbuibui requested a review from psychocoderHPC July 2, 2025 08:17
@ikbuibui ikbuibui force-pushed the fields_fix branch 4 times, most recently from c9213ea to 570ee50 Compare July 4, 2025 07:15
@ikbuibui ikbuibui force-pushed the fields_fix branch 3 times, most recently from c2f2266 to 678089f Compare July 17, 2025 16:34
@psychocoderHPC psychocoderHPC dismissed their stale review July 18, 2025 09:40

I am on vacations so an other admin can take over.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug a bug in the project's code component: plugin in PIConGPU plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants