Skip to content

Upgrade to WinUI 2.5 and other Dependencies - Deprecate RadialProgressBar #3758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
7 commits merged into from
Feb 18, 2021

Conversation

michael-hawker
Copy link
Member

Contributes to #3062

Adds deprecation message to the RadialProgressBar. Updates some of our dependencies. Few more to do, but will wait until we remove parsers and services packages.

@ghost
Copy link

ghost commented Feb 16, 2021

Thanks michael-hawker for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@michael-hawker michael-hawker added the next preview ✈️ Label for marking what we want to include in the next preview release for developers to try. label Feb 16, 2021
@ghost ghost requested review from azchohfi, Kyaa-dost and Rosuavio February 16, 2021 19:45
@michael-hawker
Copy link
Member Author

michael-hawker commented Feb 16, 2021

@azchohfi guess I missed a reference somewhere that's not done through NuGet?

Error: System.Exception: Failed to install Test Appx Package: error 0x80070002: Opening the package from location Microsoft.UI.Xaml.2.4.appx failed.
   at Windows.UI.Xaml.Tests.MUXControls.InteractionTests.Infra.TestAppInstallHelper.InstallTestAppIfNeeded(String deploymentDir, String packageName, String packageFamilyName, String appInstallerName)
   at Windows.UI.Xaml.Tests.MUXControls.InteractionTests.Infra.Application.Launch(String deploymentDir)
   at Windows.UI.Xaml.Tests.MUXControls.InteractionTests.Infra.Application.Initialize(Boolean doLaunch, String deploymentDir)
   at Windows.UI.Xaml.Tests.MUXControls.InteractionTests.Infra.TestEnvironment.Initialize(TestContext testContext, TestApplicationInfo testAppInfo)
   at UITests.Tests.SimpleTest.ClassInitialize(TestContext testContext) in /_/UITests/UITests.Tests.Shared/Examples/SimpleTest.cs:line 28

Ah, the UITests.App.dependencies.*.txt files? Anything else besides those?

@michael-hawker
Copy link
Member Author

@azchohfi any concerns?

@azchohfi
Copy link
Contributor

@azchohfi any concerns?

There was no XAML change? Thats new.

@michael-hawker
Copy link
Member Author

@azchohfi yeah, I tested out the sample app and a few of our things built on WinUI and didn't notice any problems updating to 2.5 surprising. We hit more issues with 2.4 as they redid the NavigationView.

I'll update the other version for the UWP package this morning and push that up, thanks for taking a quick look!

@michael-hawker
Copy link
Member Author

@azchohfi updated, hopefully build/release will go smoothly.

@ghost
Copy link

ghost commented Feb 17, 2021

Hello @michael-hawker!

Because this pull request has the auto merge :zap: label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit baf8adb into CommunityToolkit:master Feb 18, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto merge ⚡ maintenance ⚙️ next preview ✈️ Label for marking what we want to include in the next preview release for developers to try.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants