-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Upgrade to WinUI 2.5 and other Dependencies - Deprecate RadialProgressBar #3758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks michael-hawker for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
@azchohfi guess I missed a reference somewhere that's not done through NuGet?
Ah, the |
@azchohfi any concerns? |
Microsoft.Toolkit.Uwp.SampleApp/Microsoft.Toolkit.Uwp.SampleApp.csproj
Outdated
Show resolved
Hide resolved
...oft.Toolkit.Uwp.Samples.BackgroundTasks/Microsoft.Toolkit.Uwp.Samples.BackgroundTasks.csproj
Outdated
Show resolved
Hide resolved
UnitTests/UnitTests.HighPerformance.UWP/UnitTests.HighPerformance.UWP.csproj
Outdated
Show resolved
Hide resolved
UnitTests/UnitTests.Notifications.UWP/UnitTests.Notifications.UWP.csproj
Outdated
Show resolved
Hide resolved
UnitTests/UnitTests.XamlIslands.UWPApp/UnitTests.XamlIslands.UWPApp.csproj
Outdated
Show resolved
Hide resolved
There was no XAML change? Thats new. |
@azchohfi yeah, I tested out the sample app and a few of our things built on WinUI and didn't notice any problems updating to 2.5 surprising. We hit more issues with 2.4 as they redid the NavigationView. I'll update the other version for the UWP package this morning and push that up, thanks for taking a quick look! |
@azchohfi updated, hopefully build/release will go smoothly. |
Hello @michael-hawker! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
Contributes to #3062
Adds deprecation message to the RadialProgressBar. Updates some of our dependencies. Few more to do, but will wait until we remove parsers and services packages.