GridSplitter - Fixed issue where the grid would overflow when resizing columns with minimum width

[kbrons]

Issue: #1894

PR Type

What kind of change does this PR introduce?

• Bugfix

What is the current behavior?

When resizing columns on a grid with one or more automatic width columns with minimum width, the grid starts getting bigger and ultimately overflows.

What is the new behavior?

The resizing stops whenever the minimum width of any automatic width column would be violated.

PR Checklist

Please check if your PR fulfills the following requirements:

• Tested code with current supported SDKs
• Docs have been added/updated which fit documentation template. (for bug fixes / features)
• Sample in sample app has been added / updated (for bug fixes / features)
  • Icon has been created (if new sample) following the Thumbnail Style Guide and templates
• Tests for the changes have been added (for bug fixes / features) (if applicable)
• Header has been added to all new source files (run build/UpdateHeaders.bat)
• Contains NO breaking changes

[skendrot]

If the bottom gif is the new behavior it's still wrong. The Grid should not expand on the right if you're dragging from the left. Likewise if dragging from the right it shouldn't move the left "wall"

[kbrons]

This fix is for a specific case having two automatic width columns (left and right) and a fixed width column (center) that provoked an overflow of the grid. Investigating some more, the behavior you are describing happens when all the columns have automatic width (gif below).

The thing is, that behavior wasn't correctly defined or implemented for the case of this fix, nor the case where all the columns have a fixed width (gif below).

Taking that into account, I think the behavior of the component should be redefined and reworked, along with all the configurations of the control tested to make sure they follow that behavior.
I think that the best would be to create a new issue to redefine this component's behavior and split the efforts.

[skendrot]

The problem is ultimately the same, columns with the auto width and min width. There is essentially one bug causing more than one issue. It would be best to fix the issue with auto width and min width set

[skendrot]

The problem is ultimately the same, columns with the auto width and min width. There is essentially one bug causing more than one issue. It would be best to fix the issue with auto width and min width set

[kbrons]

I've been taking a look at the code and testing some stuff, and found that leaving only this part of the column resizing logic, everything seems to be working at first glance. Does anyone know why the code for resizing when the current or sibling columns have fixed width was added?

This is the logic that I was testing out (along with checking that neither the current and sibling column are null).

[nmetulev]

Thanks @kbrons for researching this. Moving to 3.1 - let's revisit this in more details once we ship 3.0

[kbrons]

How should we continue with this issue? Should I keep investigating a better solution to take care of the underlying issues?

[windowstoolkitbot]

This PR seems inactive. @kbrons Do you need help to complete this issue?

[windowstoolkitbot]

This PR seems inactive. @kbrons Do you need help to complete this issue?

[windowstoolkitbot]

This PR seems inactive. @kbrons Do you need help to complete this issue?

[jamers99]

When will this be merged into master and released? We're experiencing this issue in our app and would like it fixed!

[kbrons]

@michael-hawker we should discuss this for the next release

[Kyaa-dost]

I am still seeing a similar behavior and no change on my end. This is something I can talk to @michael-hawker and will test out more.

[michael-hawker]

As part of the #3062 I'd like to refactor GridSplitter, so I'll try and re-map these scenarios on top of that while testing.

[michael-hawker]

Going to close this and factor in these discussions during the refactor of GridSplitter.