Skip to content

Align RootNamespace across tests to remove "Experiment" suffix #659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 18, 2025

Conversation

Arlodotexe
Copy link
Member

Full list of changes can be found in CommunityToolkit/Tooling-Windows-Submodule#272

Requires prerequisite PR CommunityToolkit/Tooling-Windows-Submodule#273

@Arlodotexe Arlodotexe changed the title Remove "Experiment" from RootNamespace and AssemblyName Align RootNamespace across tests to remove "Experiment" suffix Mar 13, 2025
@Arlodotexe Arlodotexe self-assigned this Mar 13, 2025
@Arlodotexe Arlodotexe added the enhancement New feature or request label Mar 13, 2025
@Arlodotexe Arlodotexe moved this to 👀 In review in Toolkit 8.x Mar 13, 2025
- Components with classes matching the component name had an invalid namespace declared for test projects.
- Previously, the test namespace would have looked like `ComponentNameExperiment.Tests`, but was changed to look like `ComponentName.Tests`.
- In places where `ComponentName` is an existing class, this causes the observed error.
 -We were unable to use a unified namespace here due to the layout change it causes in the Visual Studio Test Explorer, breaking the existing grouping.
 - To fix the issue "'SomeComponent' is a namespace but is used like a type" while keeping known behavior, we simply remove the `.` in namespace declarations for `SomeComponent.Tests`.
@Arlodotexe Arlodotexe enabled auto-merge (rebase) March 18, 2025 19:29
@Arlodotexe Arlodotexe merged commit 605cd43 into main Mar 18, 2025
23 checks passed
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Toolkit 8.x Mar 18, 2025
@Arlodotexe Arlodotexe deleted the fix/tests/single-component/rootnamespace branch March 19, 2025 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants