Skip to content

Exclude uap in WinUI package, wasdk in UWP package #500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Sep 16, 2024
Merged

Exclude uap in WinUI package, wasdk in UWP package #500

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
abb9e42
Exclude uwp target under WinUI 3 build and wasdk under WinUI 2 build.
Arlodotexe Sep 6, 2024
952b239
Fixed typo in param name
Arlodotexe Sep 9, 2024
a9cb1b6
Checkout repo at ref that triggered workflow run.
Arlodotexe Sep 10, 2024
0eb1bf4
Revert "Checkout repo at ref that triggered workflow run."
Arlodotexe Sep 11, 2024
7371119
Fix incorrect step name when run under matrix
Arlodotexe Sep 11, 2024
c859b6e
Update build.yml to include 'dev/*' branches in pull_request event
Arlodotexe Sep 12, 2024
4260f00
Merge branch 'dev/rel/8.1.240912' into fix/nupkg/uap-in-winui-package
Arlodotexe Sep 12, 2024
da7a7bb
Merge branch 'dev/rel/8.1.240912' into fix/nupkg/uap-in-winui-package
Arlodotexe Sep 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,9 +261,19 @@ jobs:
with:
vs-version: '[17.9,)'

- name: Define excluded MultiTargets (WinUI 2)
if: ${{ matrix.winui == '2' }}
run: |
echo "EXCLUDED_MULTITARGETS=wasdk" >> $env:GITHUB_ENV

- name: Define excluded MultiTargets (WinUI 3)
if: ${{ matrix.winui == '3' }}
run: |
echo "EXCLUDED_MULTITARGETS=uwp" >> $env:GITHUB_ENV

# Build and pack component nupkg
- name: Build and pack component packages
run: ./tooling/Build-Toolkit-Components.ps1 -MultiTargets all -WinUIMajorVersion ${{ matrix.winui }} -DateForVersion ${{ env.VERSION_DATE }} ${{ env.VERSION_PROPERTY != '' && format('-PreviewVersion "{0}"', env.VERSION_PROPERTY) || '' }} ${{ env.ENABLE_DIAGNOSTICS == 'true' && '-EnableBinlogs' || '' }} ${{ env.ENABLE_DIAGNOSTICS == 'true' && '-Verbose' || '' }} -BinlogOutput ./ -NupkgOutput ./ -Release
run: ./tooling/Build-Toolkit-Components.ps1 -MultiTargets all -ExcludeMultiTargets ${{ env.EXCLUDED_MULTITARGETS }} -WinUIMajorVersion ${{ matrix.winui }} -DateForVersion ${{ env.VERSION_DATE }} ${{ env.VERSION_PROPERTY != '' && format('-PreviewVersion "{0}"', env.VERSION_PROPERTY) || '' }} ${{ env.ENABLE_DIAGNOSTICS == 'true' && '-EnableBinlogs' || '' }} ${{ env.ENABLE_DIAGNOSTICS == 'true' && '-Verbose' || '' }} -BinlogOutput ./ -NupkgOutput ./ -Release

# Push Pull Request Packages to our DevOps Artifacts Feed (see nuget.config)
- name: Push Pull Request Packages (if not fork)
Expand Down
Loading