(#358) Default Offline conflict resolver. #382
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a configurable default conflict resolver for offline operations, allowing users to set a fallback resolver when no entity-specific resolver is provided. Key changes include:
- Exposing
UseDefaultConflictResolveronDatasyncOfflineOptionsBuilder - Adding
DefaultConflictResolvertoOfflineOptionsand using it in option lookups - Covering the default conflict resolver path with a new integration test
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/CommunityToolkit.Datasync.Client.Test/Offline/ConflictResolver_Tests.cs | Added PushAsync_WithDefaultClientWinsResolver_ShouldResolveConflictAndRetry test |
| src/CommunityToolkit.Datasync.Client/Offline/Models/OfflineOptions.cs | Introduced DefaultConflictResolver property and applied it in GetOptions methods |
| src/CommunityToolkit.Datasync.Client/Offline/DatasyncOfflineOptionsBuilder.cs | Added _defaultConflictResolver field, UseDefaultConflictResolver method, and set builder output |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Within the code, you can use
to set a new conflict resolver.