Skip to content

(#377) Fix for possible concurrent query during pull #378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 23, 2025
Merged

(#377) Fix for possible concurrent query during pull #378

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/CommunityToolkit.Datasync.Client/Offline/Operations/PullOperationManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,10 +141,18 @@ public async Task<PullResult> ExecuteAsync(IEnumerable<PullRequest> requests, Pu
}
});

// Get requests we need to enqueue. Note : do not enqueue them yet. Context only supports one outstanding query at a time and we don't want a query from a background task being run concurrently with GetDeltaTokenAsync.
List<PullRequest> requestsToEnqueue = [];
foreach (PullRequest request in requests)
{
DateTimeOffset lastSynchronization = await context.DeltaTokenStore.GetDeltaTokenAsync(request.QueryId, cancellationToken).ConfigureAwait(false);
request.QueryDescription = PrepareQueryDescription(request.QueryDescription, lastSynchronization);
requestsToEnqueue.Add(request);
}

// Now enqueue the requests.
foreach (PullRequest request in requestsToEnqueue)
{
serviceRequestQueue.Enqueue(request);
}

Expand Down