Skip to content

docker: make sure start-collabora-online.sh is executable #12045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

meven
Copy link
Contributor

@meven meven commented May 27, 2025

Change-Id: Ifcd45544800ab45bb4782f2df3fd31cef98410db

  • Resolves: #
  • Target version: master

Summary

The run fails without it, since the user is now cool (1001) but start-collabora-online.sh is owned by root.

Signed-off-by: Méven Car <meven.car@collabora.com>
Change-Id: Ifcd45544800ab45bb4782f2df3fd31cef98410db
@timar
Copy link
Member

timar commented May 27, 2025

You say the run fails without it, but it's been like this since forever. Why and how did it fail to you?

@meven
Copy link
Contributor Author

meven commented May 27, 2025

You say the run fails without it, but it's been like this since forever. Why and how did it fail to you?

I have been testing it and it works without.
But I saw someone that needed this.

It depends if the script/start-collabora-online.sh was copied from has the other executable permission.
This would be better to have all our assertion/state dependencies independent of this.

And the fact we don't use the root user by default https://github.com/CollaboraOnline/online/pull/11232/files

@github-project-automation github-project-automation bot moved this from To Review to To Test in Collabora Online May 27, 2025
@meven meven enabled auto-merge (rebase) May 28, 2025 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: To Test
Development

Successfully merging this pull request may close these issues.

2 participants