ci: stricter linter rules

Signed-off-by: Andres Correa Casablanca <castarco@coderspirit.xyz>

Author: castarco

.eslintrc.cjs

@@ -16,6 +16,8 @@ module.exports = {
 		'import',
 		'prettier',
 		'react-refresh',
+		'sonarjs',
+		'unicorn',
 	],
 	extends: [
 		'eslint:recommended',
@@ -26,10 +28,17 @@ module.exports = {
 		'plugin:react/recommended',
 		'plugin:react/jsx-runtime',
 		'plugin:react-hooks/recommended',
+		"plugin:sonarjs/recommended",
 		'plugin:storybook/recommended',
+		'plugin:unicorn/recommended',
 		'prettier',
 	],
 	rules: {
+		// Base ESLint rules
+		'curly': 'error',
+		'sort-imports': 'error',
+
+		// TypeScript-related rules
 		'@typescript-eslint/consistent-type-exports': 'error',
 		'@typescript-eslint/consistent-type-imports': 'error',
 		"@typescript-eslint/explicit-function-return-type": "error",
@@ -40,6 +49,18 @@ module.exports = {
 		"@typescript-eslint/no-unnecessary-qualifier": "error",
 		"@typescript-eslint/prefer-readonly": "error",
 		"@typescript-eslint/prefer-readonly-parameter-types": "error",
+		"@typescript-eslint/promise-function-async": "error",
+		"@typescript-eslint/require-array-sort-compare": "error",
+		"@typescript-eslint/sort-type-constituents": "error",
+		"@typescript-eslint/switch-exhaustiveness-check": "error",
+    "no-shadow": "off", // replaced by @typescript-eslint/no-shadow
+    "@typescript-eslint/no-shadow": "error",
+    "no-return-await": "off", // replaced by @typescript-eslint/return-await
+    "@typescript-eslint/return-await": "error",
+
+		// Unicorn Rules
+		'unicorn/filename-case': 'off',
+    'unicorn/prevent-abbreviations': 'off',
 	},
 	settings: {
     react: {

package.json

@@ -63,7 +63,9 @@
     "eslint-plugin-react": "^7.33.1",
     "eslint-plugin-react-hooks": "^4.6.0",
     "eslint-plugin-react-refresh": "^0.4.3",
+    "eslint-plugin-sonarjs": "^0.20.0",
     "eslint-plugin-storybook": "^0.6.13",
+    "eslint-plugin-unicorn": "^48.0.1",
     "prettier": "^3.0.1",
     "publint": "^0.2.0",
     "react": "^18.2.0",

pnpm-lock.yaml

@@ -38,16 +38,14 @@ const _computeLeftShiftLayout = (
 	// eslint-disable-next-line @typescript-eslint/no-non-null-assertion
 	layout[depth]!.push(x)
 
-	const treeWithLayout = {
+	return {
 		data: tree.data,
 		children: tree.children?.map((child: Readonly<TreeChild>) => ({
 			edgeData: child.edgeData,
 			node: _computeLeftShiftLayout(child.node, depth + 1, layout),
 		})),
 		layout: { plan: { x, y: depth } },
 	} satisfies TreeWithLayout
-
-	return treeWithLayout
 }
 
 export const computeLeftShiftLayout: ((tree: Tree) => TreeWithLayout) = _computeLeftShiftLayout

src/core.ts

@@ -1,4 +1,4 @@
-import { describe, it, expect } from 'vitest'
+import { describe, expect, it } from 'vitest'
 import { computeLeftShiftLayout } from '../core'
 
 describe('computeLeftShiftLayout', () => {