ci: stricter linter rules

Signed-off-by: Andres Correa Casablanca <castarco@coderspirit.xyz>

Author: castarco

.eslintrc.cjs

@@ -13,17 +13,34 @@ module.exports = {
   },
 	plugins: [
 		'@typescript-eslint',
+		'import',
 		'prettier',
-		'react-refresh'
+		'react-refresh',
 	],
 	extends: [
 		'eslint:recommended',
 		'plugin:@typescript-eslint/strict-type-checked',
+		'plugin:@typescript-eslint/stylistic-type-checked',
+		'plugin:import/recommended',
+		'plugin:import/typescript',
 		'plugin:react/recommended',
 		'plugin:react/jsx-runtime',
 		'plugin:react-hooks/recommended',
-		'plugin:storybook/recommended'
+		'plugin:storybook/recommended',
+		'prettier',
 	],
+	rules: {
+		'@typescript-eslint/consistent-type-exports': 'error',
+		'@typescript-eslint/consistent-type-imports': 'error',
+		"@typescript-eslint/explicit-function-return-type": "error",
+		"@typescript-eslint/explicit-member-accessibility": "error",
+		"@typescript-eslint/explicit-module-boundary-types": "error",
+		"@typescript-eslint/no-import-type-side-effects": "error",
+		'@typescript-eslint/no-misused-promises': 'error',
+		"@typescript-eslint/no-unnecessary-qualifier": "error",
+		"@typescript-eslint/prefer-readonly": "error",
+		"@typescript-eslint/prefer-readonly-parameter-types": "error",
+	},
 	settings: {
     react: {
       version: 'detect'

package.json

@@ -58,6 +58,7 @@
     "@vitest/coverage-v8": "^0.34.1",
     "eslint": "^8.47.0",
     "eslint-config-prettier": "^9.0.0",
+    "eslint-plugin-import": "^2.28.0",
     "eslint-plugin-prettier": "^5.0.0",
     "eslint-plugin-react": "^7.33.1",
     "eslint-plugin-react-hooks": "^4.6.0",

pnpm-lock.yaml

@@ -1,15 +1,15 @@
 import type { Tree } from './core'
 
 export interface BeautifulTreeProps {
-	id: string,
-	svgProps: {
-			width: number,
-			height: number,
+	readonly id: string,
+	readonly svgProps: {
+			readonly width: number,
+			readonly height: number,
 	},
-	tree: Tree,
+	readonly tree: Tree,
 }
 
-export function BeautifulTree(props: BeautifulTreeProps) {
+export function BeautifulTree(props: Readonly<BeautifulTreeProps>): JSX.Element {
 	return (
 	<svg
 		xmlns="http://www.w3.org/2000/svg"

src/BeautifulTree.tsx

@@ -1,26 +1,34 @@
-export type TreeChild<T extends Tree = Tree> = {
-	node: T,
-	edgeData?: Record<string, unknown> | undefined,
+export interface TreeChild<T extends Tree = Tree> {
+	readonly node: T,
+	readonly edgeData?: Readonly<Record<string, unknown>> | undefined,
 }
 
-export type Node = {
-	data?: Record<string, unknown> | undefined,
+export interface Node {
+	readonly data?: Readonly<Record<string, unknown>> | undefined,
 }
 
 export type Tree = Node & {
-	children?: TreeChild[] | undefined,
+	readonly children?: readonly TreeChild[] | undefined,
 }
 
 export type TreeWithLayout = Node & {
-	children?: Required<TreeChild<TreeWithLayout>>[] | undefined,
-	layout: {
-		plan: { x: number, y: number },
+	readonly children?: Required<TreeChild<TreeWithLayout>>[] | undefined,
+	readonly layout: {
+		readonly plan: {
+			readonly x: number,
+			readonly y: number
+		},
 	}
 }
 
 type InternalTreeLayout = number[][]
 
-const _computeLeftShiftLayout = (tree: Tree, depth: number = 0, layout?: InternalTreeLayout): TreeWithLayout => {
+const _computeLeftShiftLayout = (
+		tree: Tree,
+		depth = 0,
+		// eslint-disable-next-line @typescript-eslint/prefer-readonly-parameter-types
+		layout?: InternalTreeLayout
+	): TreeWithLayout => {
 	layout ??= []
 
 	if (layout[depth] === undefined) {
@@ -32,7 +40,7 @@ const _computeLeftShiftLayout = (tree: Tree, depth: number = 0, layout?: Interna
 
 	const treeWithLayout = {
 		data: tree.data,
-		children: tree.children?.map(child => ({
+		children: tree.children?.map((child: Readonly<TreeChild>) => ({
 			edgeData: child.edgeData,
 			node: _computeLeftShiftLayout(child.node, depth + 1, layout),
 		})),