Add missing assertion tests #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
W0rma
force-pushed
the
add-tests
branch
2 times, most recently
from
f2726e6 to
ba804f7
Compare
W0rma
commented
Mar 11, 2025
|
@TavoNiievez @Naktibalda WDYT about this PR? #28 should be merged beforehand. |
|
@W0rma Please make a rebase against master. |
@TavoNiievez Done - thank you! |
|
Could this be related to https://github.com/Codeception/Codeception/actions/runs/14649174925/job/41110601647?pr=6846 ? There was 1 error:
1) AssertsTest: Php unit asserts
Test tests/unit/Codeception/Module/AssertsTest.php:testPHPUnitAsserts
Error: ;1m [Error] Call to undefined method PHPUnit\Framework\Assert::assertClassHasAttribute()
#1 /home/runner/work/Codeception/Codeception/app.php:45
#2 /home/runner/work/Codeception/Codeception/app.php:46
#3 /home/runner/work/Codeception/Codeception/codecept:7
ERRORS!
Tests: 13, Assertions: 40, Errors: 1.
Error: Process completed with exit code 1. |
This was referenced Apr 25, 2025
|
@TavoNiievez Thank you for the hint. Yes, that's related to the change because before my PR the assertions were not tested. Codeception/Codeception#6847 bumps the version of #30 does the same for the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is built on top of #28 which enables PHP 8.3 + 8.4 in the CI which is necessary to be able to install PHPUnit 12.
Tests should become green as soon as Codeception/lib-asserts#14 is merged