Skip to content

West Midlands | ITP-May - 25| Jonathan Boahene | Sprint-2 | Module-Structuring-and-Testing-Data #664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 18 commits into
base: main
Choose a base branch
from

Conversation

Abayie
Copy link

@Abayie Abayie commented Jul 17, 2025

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

Briefly explain your PR.
In this pull request I have added improved solutions and comprehensive tests for Sprint 2 of Module-Structuring-and-Testing-Data.
I refactored functions to handle edge cases and ensure correct formatting, such as converting 24-hour time strings to 12-hour clock format with am/pm.
The code now includes robust test cases for different input scenarios, including midnight, noon, single-digit hours, and times close to midnight and noon.
These changes enhance reliability and maintainability, making the code easier to understand and verify for a wide range of data inputs.

Questions

Ask any questions you have for your reviewer.

@Abayie Abayie added the Needs Review Participant to add when requesting review label Jul 17, 2025
@Abayie Abayie changed the title West Midlands | ITP-May | Jonathan Boahene | Sprint-2 | Module-Structuring-and-Testing-Data West Midlands | ITP-May - 25| Jonathan Boahene | Sprint-2 | Module-Structuring-and-Testing-Data Jul 17, 2025
Copy link
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Code is solid and explanation is clear. Great job!

  • This branch contains some unrelated modified files in the Sprint-1 folder. Can you revert the changes in the Sprint-1 folder?

image

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review and removed Needs Review Participant to add when requesting review labels Jul 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Reviewed Volunteer to add when completing a review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants