West Midlands | ITP-May - 25| Jonathan Boahene | Sprint-1 |Module-Structuring-and-Testing-Data #663
+214
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Abayie
changed the title
cjyuan
added
Review in progress
cjyuan
reviewed
Jul 17, 2025
Comment on lines
+7
to
+10
|
|
||
| /*Line 3 is reassigning variable count with a new value, in this case we're saying add 1 to whatever we already have in count, | ||
| and so by using the console.log before and after the reassignment the we can tell new value of count is 1 | ||
| */ |
There was a problem hiding this comment.
Operation like count = count + 1 is very common in programming, and there is a programming term describing such operation.
Can you find out what one-word programming term describes the operation on line 3?
| /* SOLUTION | ||
| a) **How many variable declarations are there in this program?** | ||
| There are **5** variable declarations: `movieLength`, `remainingSeconds`, `totalMinutes`, `remainingMinutes`, `totalHours`, and `result`. |
There was a problem hiding this comment.
You listed all declared variables but miscounted them. :D
Comment on lines
+40
to
+41
| 5. const pence = paddedPenceNumberString.substring(paddedPenceNumberString.length - 2).padEnd(2, "0"); | ||
| Extracts the last two characters for the pence part (e.g., from "399", it takes "99"). If there are fewer than two characters, it pads the result on the right with zeros. |
There was a problem hiding this comment.
Could we expect this program to work as intended for any valid penceString if we deleted .padEnd(2, "0") from the code?
In other words, do we really need .padEnd(2, "0") in this script?
cjyuan
added
Reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
This pull request improves code readability and data formatting for Sprint 1 of Module-Structuring-and-Testing-Data.
I refactored programs to clearly convert and format values, such as transforming pence strings to pounds, formatting time values, and calculating percentage changes.
Each solution includes step-by-step breakdowns and explanations, ensuring the code is easy to follow and works correctly for different input cases.
Questions
Ask any questions you have for your reviewer.