Skip to content

WESTMIDLANDS | ITP-MAY-25 | AHMAD EHSAS | MODULE STRUCTURING AND TESTING DATA SPRINT-3 #656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

WESTMIDLANDS | ITP-MAY-25 | AHMAD EHSAS | MODULE STRUCTURING AND TESTING DATA SPRINT-3 #656

wants to merge 15 commits into from
+3,561 −50

Conversation

ahmadehsas
Copy link

@ahmadehsas ahmadehsas commented Jul 12, 2025 •
edited
Loading

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with REGION | COHORT_NAME | FIRST_NAME LAST_NAME | PROJ_NAME
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

Briefly explain your PR.

Completed sprint-3, dealing with errors and understanding the flow of a program

Questions

ahmadehsas added 15 commits June 16, 2025 17:22
@ahmadehsas
Answered comment for count update in exercise -1
65fe894
@ahmadehsas
Implement getAngleType with complete test coverage and improved test …
532fd66 
…feedback
@ahmadehsas
Completed the rest the tests and cases
0cba6bb
@ahmadehsas
Implement getCardValue function with test cases for number, face, ace…
8d6eb95 
…, and invalid cards
@ahmadehsas
Implement getAngleType function to classify angle types
2479c4f
@ahmadehsas
Add test cases for angle types and update Sprint-1 readme
3fafedf
@ahmadehsas
Added function(isProperFraction)
7a5fe08
@ahmadehsas
Identified Improper, Negative and equal fractions.
68f5551
@ahmadehsas
Rewrote the Card value function and tests
5dd3b88
@ahmadehsas
completed the countChar function with a short clear description and t…
62ef41d 
…he goal of this function is to count how many times a specific character appears in a given string
@ahmadehsas
completed the No occurrences Scenario test
1443cbf
@ahmadehsas
completed the function getOrdinalNumber.
1e2318b
@ahmadehsas
the test is passed for get-ordinal-number.js
edea881
@ahmadehsas
Implemented the function and the test was passed
dbf4e92
@ahmadehsas
Edited incorrect test cases and fixed logic to ensure all tests pass …
fad2100 
…successfully.
@ahmadehsas ahmadehsas added the Needs Review Participant to add when requesting review label Jul 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review Participant to add when requesting review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ahmadehsas