London|MAY_2025|FATMA_DEGIRMENCI|STRUCTRING_AND_TESTING_DATA| SPRINT 3

[fatmaevin]

Self checklist

• I have committed my files one by one, on purpose, and for a reason
• I have titled my PR with REGION | COHORT_NAME | FIRST_NAME LAST_NAME | PROJ_NAME
• I have tested my changes
• My changes follow the style guide
• My changes meet the requirements of this task

[cjyuan]

The spec isn't clear whether angle can be assigned a number not in the interval (0, 360).
When angle is >= 360, what should the function return? (Also, by definition, angles <= 0 are not considered acute angles.)

When we implement a function that can return a value, to ensure reliability, we should ensure it will always return a defined value instead of undefined (which represents "no return value").
If the parameter, angle, is not within the recognised range, we can design the function to return a special value (e.g., "Invalid angle") or throw an error.

[cjyuan]

• Returning undefined in JS has the same meaning as "no return value".

• We could also return false when the parameters cannot form a proper fraction. Technically, 1/0 or 0/1 are not proper fractions.

[cjyuan]

In JavaScript, strings that represent valid numeric literals in the language can be safely converted to equivalent numbers. For examples, "0x02", "2.1", or "00_02".

Does your function return the value you expected from each of the following function calls?

getCardValue("0x02♠");
getCardValue("2.1♠");
getCardValue("00_02♠");

[cjyuan]

When preparing tests, we should ensure the tests cover all possible cases. If we specify a test for individual card, we will need about 53 tests to cover all possible cases. Instead, we could consider classifying all possible values into different categories, and then within each category we test some samples.

For example, one possible category for getCardValue() is, "should return the value of number cards (2-10)", and we can prepare the test as

test("should return the value of number cards (2-10)", () => {
    expect(getCardValue("2♣︎")).toEqual(2);
    expect(getCardValue("5♠")).toEqual(5);
    expect(getCardValue("10♥")).toEqual(5);
    // Note: We could also use a loop to check all values from 2 to 10.
});

[cjyuan]

We could generalise this test to "should return 10 for face cards (J, Q, K)" and check all three ranks J, Q, K.

[cjyuan]

getOrdinalNumber(511) should return "511th".
Consider looking up the rules to clarify how ordinal numbers are formed.

[cjyuan]

To ensure thorough testing, we need broad scenario coverage. Listing individual values, however, can quickly lead to an unmanageable number of test cases.
Instead of writing tests for individual numbers, consider grouping all possible input values into meaningful categories. Then, select representative samples from each category to test. This approach improves coverage and makes our tests easier to maintain.

For example, we can prepare a test for numbers 2, 22, 132, etc. as

test("append 'nd' to numbers ending in 2, except those ending in 12", () => {
    expect( getOrdinalNumber(2) ).toEqual("2nd");
    expect( getOrdinalNumber(22) ).toEqual("22nd");
    expect( getOrdinalNumber(132) ).toEqual("132nd");
});

Can you update the tests in this script so that they can cover all valid integers?

[cjyuan]

• Avoid using invalid passwords as one of previous passwords.

• Could also consider accepting previousPasswords array through the 2nd parameter so that the callers have the flexibility to specify previous passwords.

[cjyuan]

The tests in this script should also check if the function can return false when the password satisfies all other conditions except the one described in the test.

For example,

test("password has at least 5 characters", () => {
    // This password contains each of the required characters but is too short
    expect( isValidPassword("Aa1$") ).toEqual(false);
}